fix(vaults): durable invitationMakers

[turadg]

Description

The Far object for invitationMakers in the vault offer result cannot be stored durably. This fixes that by making it a durable facet. Combined with #7294 the vault offer result can be stored durably.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

CI

[dckc]

I can see how CI would make sure this doesn't cause regressions, but normally a fix comes with a test that shows what was broken. Is that not cost-effective?

Perhaps the stress tests coming from #7219 are what show that this fixes something?

[turadg]

normally a fix comes with a test that shows what was broken. Is that not cost-effective?

Good question! I don't see it as cost effective to do in CI because we'd have to observe the Zoe seat. That would require one of:

• instrumentation on the ephemeralOfferResultStore size
• emitting events for failure to store durably
• a way for CI to grep the console output

The test-vaults-performance that runs out of CI could do by observing the heap growth of many retained offer results. I think that's possible using process.memoryUsage() but we'd need to fix #7297 and have the BYOD invoker that @warner is working on.

I agree we should try to have a test before closing that so I'll add that to the ticket.

[dckc]

good idea