Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing branch for stress test vault creation #7219

Closed
wants to merge 10 commits into from
Closed

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 22, 2023

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@turadg turadg requested a review from arirubinstein March 22, 2023 20:56
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #7219 (536fa6b) into master (4874362) will decrease coverage by 13.18%.
The diff coverage is 91.30%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7219       +/-   ##
===========================================
- Coverage   79.40%   66.22%   -13.18%     
===========================================
  Files         390      313       -77     
  Lines       73961    60120    -13841     
  Branches        3        3               
===========================================
- Hits        58729    39816    -18913     
- Misses      15231    20236     +5005     
- Partials        1       68       +67     
Impacted Files Coverage Δ
packages/zoe/src/zoeService/zoeSeat.js 96.84% <90.90%> (+4.27%) ⬆️
...ackages/zoe/src/zoeService/instanceAdminStorage.js 97.35% <100.00%> (ø)

... and 216 files with indirect coverage changes

Impacted file tree graph

@datadog-full-agoric
Copy link

datadog-full-agoric bot commented Mar 22, 2023

Datadog Report

Branch report: 7218-stress-vaults
Commit report: 6e4f783

agoric-sdk: 1 Failed (0 Known Flaky), 0 New Flaky, 2602 Passed, 21 Skipped, 31m 16.32s Wall Time

❌ Failed Tests (1)

  • bootstrapTests › vaults-performance › before hook - agoric.vats - Details

    Expand for error
     ---
         name: AssertionError
         message: Rejected promise returned by test
         values:
           'Rejected promise returned by test. Reason:': |-
             TypeError {
               code: 'ERR_INVALID_ARG_TYPE',
               message: 'The "path" argument must be of type string or an instance of Buffer or URL. Received undefined',
             }
         at: >-
     ...
    

@turadg turadg force-pushed the 7218-stress-vaults branch from 4efc380 to 189942b Compare March 24, 2023 18:17
@turadg turadg requested a review from mhofman March 24, 2023 18:29
@turadg turadg force-pushed the 7218-stress-vaults branch from 42180a4 to 11128c4 Compare March 29, 2023 23:38
@mhofman
Copy link
Member

mhofman commented Mar 31, 2023

Removing myself from reviewers since I believe this PR / branch has turned into a playground to diagnose heap leaks.

@mhofman mhofman removed their request for review March 31, 2023 16:02
@turadg turadg changed the title test(bootstrap): stress test vault creation testing branch for stress test vault creation Mar 31, 2023
@turadg turadg closed this May 4, 2023
@turadg turadg deleted the 7218-stress-vaults branch May 4, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants