fix: remove addInstance call from add-auction.js

[frazarshad]

closes: #XXXX
refs: #XXXX

Description

removes the call to addInstance made in add-auction.js
This is to stop it from breaking another call to addInstance made in the replace-electorate.js proposal for the same instance

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	d16781f
Status:	✅  Deploy successful!
Preview URL:	https://d2a50e0b.agoric-sdk.pages.dev
Branch Preview URL:	https://fraz-fix-auctioneer-addinsta.agoric-sdk.pages.dev

View logs

[Chris-Hibbert]

I'd prefer to remove the copy in replaceElectorate.js. That version made it necessary to add a dependency between the two proposals. Now that the two proposals are started in a known order in a software upgrade, it makes sense to not bother with that interconnection.

  await E(ecCreatorFacet).addInstance(
    auctionUpgradeNewInstance,
    auctionUpgradeNewGovCreator,
    'auctioneer',
  );

Cleaning that up completely requires changing the auction proposal to not provide auctionUpgradeNewInstance and auctionUpgradeNewGovCreator. I can make that change to the PR if you like. Or we could say that that's a bigger change to the RC, and not worth it. This approach works, and is less code. It just leaves messier proposals behind.

[frazarshad]

@Chris-Hibbert imo a less code approach would be preferable for a fix unless you feel strongly about decoupling the proposals