chore: upgrade-18 cherry-picks round 2 #10460
Open
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
reviewed
Nov 13, 2024
| @@ -18,6 +18,7 @@ var upgradeNamesOfThisVersion = []string{ | |||
| "agoric-upgrade-18-devnet", | |||
| "agoric-upgrade-18-emerynet", | |||
| "agoric-upgrade-18-basic", | |||
| "agoric-upgrade-18-basic-2", | |||
There was a problem hiding this comment.
While it doesn't change the behavior, we should have this new name return false in isPrimaryUpgradeName
There was a problem hiding this comment.
I'm also wondering if we should bikeshed the name as it's not really like basic or meant to be applied on its own
There was a problem hiding this comment.
I'm also wondering if we should bikeshed the name as it's not really like basic or meant to be applied on its own
what do you suggest?
I can work on this today, and then attach it to this PR's description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks the following commits from master:
Also adds a new upgrade name
agoric-upgrade-18-basic-2.used
git cherry-pickfor the above commits