Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert eslint to @agoric #3355

Closed
wants to merge 1 commit into from
Closed

Conversation

kriskowal
Copy link
Member

ESlint no longer works in VS Code, though it works fine as a build step and in CI. This reverts the migration from @agoric/eslint* to @endo/* until we can make VS Code work recognize the version installed in node_modules.

@kriskowal kriskowal requested review from dckc and Chris-Hibbert June 18, 2021 16:57
@kriskowal
Copy link
Member Author

We found an alternate resolution. VS Code > Developer > Reload Window.

@kriskowal kriskowal closed this Jun 18, 2021
@dckc
Copy link
Member

dckc commented Jun 18, 2021

There's a Developer menu? I don't see it. @mhofman ?

I did File > Exit and start again.

@mhofman
Copy link
Member

mhofman commented Jun 18, 2021

Command palette (Ctrl + P), "Developer: reload window"

@dckc
Copy link
Member

dckc commented Jun 18, 2021

ah. thanks.

I squirreled that away in https://github.com/Agoric/agoric-sdk/wiki/Coding-Style#vs-code-eslint-plugin-flakiness , though it should perhaps move somewhere nearby.

@kriskowal kriskowal deleted the kris-revert-eslint-endo branch February 14, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants