feat(eslint-config): Demos entrain devDependencies #3638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
527-eslint-demos
branch
2 times, most recently
from
ed26fbd to
775fc17
Compare
kriskowal
force-pushed
the
527-eslint-demos
branch
from
775fc17 to
b7a8f38
Compare
kriskowal
force-pushed
the
527-import-manager
branch
from
aa307bf to
5729f18
Compare
kriskowal
force-pushed
the
527-eslint-demos
branch
from
b7a8f38 to
05958ae
Compare
*BREAKING CHANGE*: makeHelpers no longer provides path resolution functions resolvePathForLocalContract nor resolvePathForPackagedContract. We have ensured that example contracts no longer uses these deployment helpers, and we intend to eventually restore them, but with different, asynchronous function signatures, after we complete our migration to Node.js native ESM (modules).
This change also incidentally removes a dependency on path in favor of using the thread read powers. This frees up the name dirname in module scope for our adapter to import.module.url.
kriskowal
force-pushed
the
527-import-manager
branch
from
5729f18 to
caa72d7
Compare
kriskowal
force-pushed
the
527-eslint-demos
branch
from
05958ae to
859040b
Compare
kriskowal
force-pushed
the
527-import-manager
branch
from
caa72d7 to
464f8e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, eslint would suggest that dependencies that occur under demo directories should be retained in the
dependencies, notdevDependencies, of the surroundingpackage.json. Demos should not entrain published package dependencies. This change configures eslint to recognize the demo directories as having the same footing as tests and scripts.Refs #527