Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimise integration test #4113

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Nov 23, 2021

Description

Speed up the integration test CI by not printing out a whole endo bundle (the Github Actions don't handle that very well).

Before

image

After

image

Conclusion

48 minutes down to 13 minutes.

Security Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig self-assigned this Nov 23, 2021
@michaelfig michaelfig added the solo the solo node (packages/solo) label Nov 23, 2021
@michaelfig michaelfig force-pushed the mfig-ci-optimise-integration-test branch from 9673a4c to 831d209 Compare November 23, 2021 05:27
@michaelfig michaelfig changed the title Mfig ci optimise integration test ci: optimise integration test runtime Nov 23, 2021
@michaelfig michaelfig changed the title ci: optimise integration test runtime ci: optimise integration test Nov 23, 2021
@michaelfig michaelfig marked this pull request as ready for review November 23, 2021 05:46
@michaelfig michaelfig requested review from dckc and kriskowal November 23, 2021 05:46
@michaelfig michaelfig force-pushed the mfig-ci-optimise-integration-test branch 2 times, most recently from 4268eeb to 15cae21 Compare November 23, 2021 06:04
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well played

@michaelfig michaelfig force-pushed the mfig-ci-optimise-integration-test branch 2 times, most recently from 77843b7 to 831d209 Compare November 23, 2021 15:06
@michaelfig
Copy link
Member Author

well played

Thanks. Unfortunately, the problem appears to be in the length of the console.debug message, not whether it was displayed, so the elegant cut solution didn't give the same results as the more intrusive environment variable and JS code change.

Would you please have another look? I don't want to assume you have no comments. :)

@michaelfig michaelfig requested a review from dckc November 24, 2021 00:21
@dckc
Copy link
Member

dckc commented Nov 24, 2021

Yes, the SOLO_MAX_DEBUG_LENGTH thing looks good too. I already saw it; I guess I neglected to say so.

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Nov 24, 2021
@mergify mergify bot merged commit a5ea90c into master Nov 24, 2021
@mergify mergify bot deleted the mfig-ci-optimise-integration-test branch November 24, 2021 07:31
mhofman added a commit to Agoric/testnet-load-generator that referenced this pull request Jan 17, 2022
- Update to node 16 and Debian bullseye (with fallback to node 14 for older incompatible SDKs)
- Handle some older SDK versions which output lockdown sniffing to stdout instead of stderr
- Rewrote the config argv parsing logic, to make it behave slightly more sanely
- Fixed some deadlock issues, e.g. adding some timeouts on task ready (see #40) or slog streams not closing properly
- Capture client storage and slog file (should help track some transient seg faults in the solo)
- Automatically capture the state of the client and chain if an error occurs (see #39)
- Background the compression of the state directories after snapshotting them (overlayfs supports CoW). Closes #39 
- Avoid resetting the whole `agoric-servers` project in `local-chain` tests. Removes loadgen project `git` dependency.
- Elide long lines from the chain or solo output (improves github actions perf, see Agoric/agoric-sdk#4113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates solo the solo node (packages/solo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants