Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimise integration test #4113

Merged
merged 3 commits into from
Nov 24, 2021
Merged

ci: optimise integration test #4113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7087181
fix(solo): trim overlong message bodies in debug logs
michaelfig Nov 23, 2021
831d209
ci(integration): reduce amount of test output to optimise
michaelfig Nov 23, 2021
69fafb2
Merge branch 'master' into mfig-ci-optimise-integration-test
mergify[bot] Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,8 @@ jobs:

- name: run agoric-cli integration-test
working-directory: ./packages/agoric-cli
run: PATH="$PATH:$HOME/bin" AGORIC_INIT_OPTIONS='["--dapp-branch=${{steps.get-branch.outputs.result}}"]' yarn integration-test
run: PATH="$PATH:$HOME/bin" yarn integration-test
env:
AGORIC_INIT_OPTIONS: '["--dapp-branch=${{steps.get-branch.outputs.result}}"]'
# Try to avoid hitting a pessimal Actions output rate-limitation.
SOLO_MAX_DEBUG_LENGTH: '1024'
11 changes: 11 additions & 0 deletions docs/env.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,17 @@ Same as SLOGFILE, but for solo instead of chain.

Lifetime: ?

## SOLO_MAX_DEBUG_LENGTH

Affects: solo

Purpose: reduce the size of each individual `console.debug` output

Description: defaults to no limit, set to a decimal byte count to reduce the
output

Lifetime: Until CI no longer balks on long output, or our source bundles aren't delivered via messages to the sim-chain

## SLOGFILE

Affects: cosmic-swingset
Expand Down
12 changes: 11 additions & 1 deletion packages/solo/src/outbound.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
/* global process */
import anylogger from 'anylogger';

import { assert, details as X } from '@agoric/assert';

// Limit the debug log length.
const SOLO_MAX_DEBUG_LENGTH =
Number(process.env.SOLO_MAX_DEBUG_LENGTH) || undefined;

const log = anylogger('outbound');

/**
Expand Down Expand Up @@ -31,7 +36,12 @@ export function deliver(mbs) {
data[target].outbox.forEach(m => {
const [msgnum, body] = m;
if (msgnum > t.highestSent) {
log.debug(`new outbound message ${msgnum} for ${target}: ${body}`);
log.debug(
`new outbound message ${msgnum} for ${target}: ${body}`.slice(
0,
SOLO_MAX_DEBUG_LENGTH,
),
);
newMessages.push(m);
}
});
Expand Down