Execute vat creation and root object initialization in a crank #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
force-pushed
the
2910-vat-setup-as-crank
branch
from
383e015 to
e0ec2fd
Compare
warner
requested changes
Feb 18, 2022
| @@ -258,6 +279,10 @@ test.serial('bootstrap export', async t => { | |||
| } | |||
|
|
|||
| t.deepEqual(c.dump().log, []); | |||
| for (let i = 0; i < 7; i += 1) { | |||
| // eslint-disable-next-line no-await-in-loop | |||
| await stepGC(); // vat starts | |||
There was a problem hiding this comment.
but not this
huh, with only 6 non-setup vats, I'd expect the loop should need 6 iterations, not 7. And the deleted stepGC below (the // dropExports) one sort of correlates with that. But I'm guessing the test failed when you do 6 loops and retain the // dropExports one?
There was a problem hiding this comment.
I'm reopening this as I was just stung by this in my change to the run queue. Switching to 6 and restoring the second stepGC below fixed the issue (after a while of tracing the diff).
|
@warner ready for re-review. I put all the changes in a separate commit for ease of reviewing. I'll squash it out when landing, assuming everything is OK. |
FUDCo
force-pushed
the
2910-vat-setup-as-crank
branch
from
b355fea to
1054d44
Compare
warner
approved these changes
Feb 22, 2022
…call and transcript logging Closes #2910
FUDCo
force-pushed
the
2910-vat-setup-as-crank
branch
from
1054d44 to
2218e07
Compare
mhofman
added a commit
that referenced
this pull request
Feb 22, 2022
mhofman
added a commit
that referenced
this pull request
Feb 22, 2022
mhofman
added a commit
that referenced
this pull request
Feb 24, 2022
mhofman
added a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run vat creation and initialization in a crank, so module initialization and
buildRootObjecthave access to syscalls and have their actions logged in the vat transcript.Closes #2910