Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix swingset/test/test-controller.js leftovers #4632

Closed
warner opened this issue Feb 22, 2022 · 0 comments · Fixed by #4678
Closed

fix swingset/test/test-controller.js leftovers #4632

warner opened this issue Feb 22, 2022 · 0 comments · Fixed by #4678
Assignees
@gibson042
Labels
enhancement New feature or request SwingSet package: SwingSet
Milestone
Mainnet 1 RC0

Comments

@warner
Copy link
Member

warner commented Feb 22, 2022

#4575 (comment) highlights a problem in swingset's test-controller.js, two tests refer to a basedir-controller-2/bootstrap.js which got mangled during some ancient refactoring and no longer exercises what it's supposed to.

To fix, that file needs to define a bootstrap() method that emits the log string, and the two tests ('bootstrap' and 'XS bootstrap') should both use c.run() to let everything run to completion.
@warner warner added enhancement New feature or request SwingSet package: SwingSet labels Feb 22, 2022
@warner warner mentioned this issue Feb 22, 2022
Merged
@gibson042 gibson042 mentioned this issue Feb 25, 2022
Merged
gibson042 added a commit that referenced this issue Feb 26, 2022
@gibson042
test(SwingSet): Run bootstrap test vat controllers to completion
566da6d 
Fixes #4632
@mergify mergify bot closed this as completed in #4678 Feb 26, 2022
mergify bot pushed a commit that referenced this issue Feb 26, 2022
@gibson042
test(SwingSet): Run bootstrap test vat controllers to completion (#4678)
5647d10 
Fixes #4632
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Milestone
Mainnet 1 RC0
Development

Successfully merging a pull request may close this issue.

test(SwingSet): Run bootstrap test vat controllers to completion Agoric/agoric-sdk
3 participants
@warner @Tartuffo @gibson042