test(SwingSet): Run bootstrap test vat controllers to completion

[gibson042]

closes: #4632

Description

Replace manual step() calls with run() in SwingSet vat controller testing.

Security Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

See above.

[FUDCo]

So that solves the mystery of why the test broke for me when I tried to replace the loop of c.step() calls with a c.run() and now I feel kinda stupid :-)

[gibson042]

Not at all, I didn't see it until running buildVatController with verbose: true produced output like

processQ {"type":"send","target":"ko21","msg":{"method":"bootstrap","args":{"body":"[{\"bootstrap\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: vref\",\"index\":0},\"comms\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: vref\",\"index\":1},\"timer\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: vref\",\"index\":2},\"vatAdmin\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: vref\",\"index\":3},\"vattp\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: vref\",\"index\":4}},{\"vatAdmin\":{\"@qclass\":\"slot\",\"iface\":\"Alleged: device\",\"index\":5}}]","slots":["ko21","ko22","ko23","ko20","ko24","kd30"]},"result":"kp40"}}
@ko21 <- bootstrap({bootstrap: @ko21, comms: @ko22, timer: @ko23, vatAdmin: @ko20, vattp: @ko24}, {vatAdmin: @kd30}) : @kp40
Add mapping k->v v1.c.ko22<=>v1.c.o-50
Add mapping k->v v1.c.ko23<=>v1.c.o-51
Add mapping k->v v1.c.ko20<=>v1.c.o-52
Add mapping k->v v1.c.ko24<=>v1.c.o-53
Add mapping k->v v1.c.kd30<=>v1.c.d-70
Add mapping k->v v1.c.kp40<=>v1.c.p-60
Logging sent error stack (TypeError#1)
TypeError#1: target has no method bootstrap , has []
TypeError: target has no method "bootstrap", has []

[FUDCo]

Yeah, but the error message 'target has no method "bootstrap"' pretty much tells the whole story, AND IT WAS RIGHT THERE...

[warner]

Perfect. One nit: please put the closes #4632 line in the git commit comment, not just the GitHub discussion comment, so later code archaeologists can work their way back to the original issue and any discussion. (obviously not a lot for this issue, but it's a general practice I want to encourage).