feat(smartWallet): defer deposits until purse available #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
requested changes
Sep 9, 2022
| const amountPKeywordRecord = objectMap(paymentKeywordRecord, payment => | ||
| E(purseForBrand(payment.getAllegedBrand())).deposit(payment), | ||
| const amountPKeywordRecord = objectMap(payouts, paymentRef => | ||
| E.when(paymentRef, payment => depositFacet.receive(payment)), |
There was a problem hiding this comment.
👍 good idea to re-use the depositFacet
| */ | ||
| async receive(payment) { | ||
| /** @type {State} */ | ||
| const { brandPurses } = this.state; | ||
| const { brandPurses, paymentQueues: queues } = this.state; | ||
| const brand = await E(payment).getAllegedBrand(); | ||
| const purse = brandPurses.get(brand); |
There was a problem hiding this comment.
This get will throw rather than returning undefined, no?
There was a problem hiding this comment.
yes good catch! I added a unit test for regression and it caught a missing harden too.
turadg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supporting #6157
Description
Some brands aren't available when a payments to the deposit facet. In this case we now hold the payments in a queue and when the purse is available we deposit all of them.
The payouts handler now uses the deposit facet to get the same feature. It also attempts each payout separately instead of the previous behavior of blocking until all payments were available.
Security Considerations
Deposits are unpermissioned so queuing them opens an attack to grow the queue unbounded. The collections are durable which should mitigate RAM consumption. If there are more problems in practice the queue size can be capped. I considered doing that in this PR but considered a worse vulnerability is for an attacker to fill the queue of a wallet and prevent legitimate deposits.
Documentation Considerations
--
Testing Considerations
--