Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smart-wallet): missing E() around remote payment #6173

Closed
wants to merge 1 commit into from
Closed

fix(smart-wallet): missing E() around remote payment #6173

wants to merge 1 commit into from

Conversation

dckc
Copy link
Member

@dckc dckc commented Sep 10, 2022

closes: #XXXX
refs: #XXXX

Description

Security Considerations

Documentation Considerations

Testing Considerations

@dckc dckc requested a review from turadg September 10, 2022 02:00
erights
erights approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a PR description, LGTM.

(I'm confident of this change even in my overall ignorance of the smart wallet).

@turadg
Copy link
Member

turadg commented Sep 10, 2022

Had been fixed in #6172

@turadg turadg closed this Sep 10, 2022
@dckc
Copy link
Member Author

dckc commented Sep 10, 2022

I must not have been caught up when I was testing.

@dckc dckc deleted the dc-sw-missing-e branch December 20, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights approved these changes

@turadg turadg Awaiting requested review from turadg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dckc @turadg @erights