refactor: no deep marshal imports #6792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2023
erights
force-pushed
the
markm-no-deep-marshal-imports
branch
from
4ab5c24 to
5638601
Compare
This was referenced Jan 24, 2023
erights
force-pushed
the
markm-no-deep-marshal-imports
branch
from
5638601 to
8524916
Compare
turadg
reviewed
Jan 24, 2023
turadg
changed the title
turadg
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
LGTM. I see the additional commit. Best to squash since it's not relevant to the git history or changelog.
For the changelog message, this is not a change to behavior so "refactor" is more appropriate than "fix". I've taken the liberty of changing the PR title.
automerge:squash should turn all the changes here into one commit with the refactor: message.
|
Closing in favor of #7427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6830
or should before it is merged. This is a new requirement so please let me know of any significant impediments.
Fixes #6831
or should before it is merged. This is a new requirement so please let me know of any significant impediments.
Won't work until agoric-sdk upgraded to depend on endojs/endo#1447
See endojs/endo#1447 for an explanation of why this is somewhat urgent.