Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stale copies #7427

Merged
merged 1 commit into from
Apr 15, 2023
Merged

refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stale copies #7427

merged 1 commit into from
Apr 15, 2023

Conversation

erights
Copy link
Member

@erights erights commented Apr 15, 2023

Replaces #6792

Now that agoric-sdk has been updated to depend on the latest endo, this PR deletes the shadow files in agoric-sdk that were mere duplicates of files that were migrated to endo. This completes the migration.

@erights erights requested review from turadg and FUDCo April 15, 2023 00:59
@erights erights self-assigned this Apr 15, 2023
@erights erights mentioned this pull request Apr 15, 2023
Closed
@erights erights requested a review from dckc April 15, 2023 01:07
@turadg
Copy link
Member

turadg commented Apr 15, 2023

The message says fix: but I think this is intended to change no behavior. Consider a message like, refactor: adopt Endo's exo and patterns. (or BREAKING CHANGE: but I don't see any breaks; some deep imports might be affected by they're not a supported part of the APIs)

@erights erights changed the title fix: delete endo shadows refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stake copies Apr 15, 2023
@erights erights changed the title refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stake copies refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stale copies Apr 15, 2023
@erights
Copy link
Member Author

erights commented Apr 15, 2023

The message says fix: but I think this is intended to change no behavior. Consider a message like, refactor: adopt Endo's exo and patterns. (or BREAKING CHANGE: but I don't see any breaks; some deep imports might be affected by they're not a supported part of the APIs)

Done with slightly different wording.

erights
erights commented Apr 15, 2023
View reviewed changes
packages/store/src/stores/store-utils.js Show resolved Hide resolved
packages/store/src/stores/store-utils.js Show resolved Hide resolved
packages/store/src/types.js Show resolved Hide resolved
packages/zoe/src/contracts/callSpread/calculateShares.js Outdated Show resolved Hide resolved
packages/ERTP/src/paymentLedger.js Show resolved Hide resolved
packages/zoe/src/contractSupport/recorder.js Show resolved Hide resolved
@erights erights requested a review from turadg April 15, 2023 02:42
turadg
turadg approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@erights erights added the automerge:no-update (expert!) Automatically merge without updates label Apr 15, 2023
@mergify mergify bot merged commit af52307 into master Apr 15, 2023
@mergify mergify bot deleted the markm-delete-endo-shadows branch April 15, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@FUDCo FUDCo Awaiting requested review from FUDCo

@dckc dckc Awaiting requested review from dckc

Assignees

@erights erights

Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @turadg