Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-components): read wallet offer public subscribers #6876

Merged
merged 4 commits into from
Jan 28, 2023
Merged

feat(web-components): read wallet offer public subscribers #6876

merged 4 commits into from
Jan 28, 2023

Conversation

samsiegart
Copy link
Contributor

@samsiegart samsiegart force-pushed the read-offer-subscribers branch from 87e6297 to 9255fef Compare January 28, 2023 08:08
@samsiegart samsiegart requested a review from turadg January 28, 2023 08:09
@samsiegart samsiegart marked this pull request as ready for review January 28, 2023 08:10
@turadg turadg force-pushed the read-offer-subscribers branch from 9255fef to ba0766d Compare January 28, 2023 15:30
turadg
turadg approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new typedef was a good idea but the type isn't quite right. I checked this out to fix the types. For expedience I made all the changes I would have asked for and pushed.

So I think this is ready to merge :) If you're not on board with any of the changes, feel free to continue to modify and re-request review.

@turadg turadg mentioned this pull request Jan 28, 2023
Merged
@samsiegart samsiegart added automerge:squash Automatically squash merge automerge:rebase Automatically rebase updates, then merge labels Jan 28, 2023
@samsiegart samsiegart force-pushed the read-offer-subscribers branch from 9481587 to 7afe26d Compare January 28, 2023 17:41
@samsiegart samsiegart force-pushed the read-offer-subscribers branch from 7afe26d to f02f60a Compare January 28, 2023 18:04
@mergify mergify bot merged commit ec2213a into master Jan 28, 2023
@mergify mergify bot deleted the read-offer-subscribers branch January 28, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsiegart @turadg