Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up no-continue #6877

Merged
merged 2 commits into from
Jan 29, 2023
Merged

clean up no-continue #6877

merged 2 commits into from
Jan 29, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 28, 2023

Description

#6739 disabled the no-continue. In #6876 I had to suppress it for web-components because it extended the Endo config.

This makes that package extend Agoric config instead. It also deletes other no-continue suppressions.

But I think we should also disable no-continue in Endo. WDYT reviewers ?

michaelfig
michaelfig approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd be fine with changing the Endo linting rules, but we have other stakeholders there, so should solicit their opinions. I'll mention it in the next Endo sync meeting.

@turadg turadg added automerge:no-update (expert!) Automatically merge without updates automerge:rebase Automatically rebase updates, then merge and removed automerge:no-update (expert!) Automatically merge without updates labels Jan 28, 2023
@mergify mergify bot merged commit db6ffeb into master Jan 29, 2023
@mergify mergify bot deleted the ta/no-continue branch January 29, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @michaelfig