Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up no-continue #6877

Merged
merged 2 commits into from
Jan 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-continue */
import fs from 'fs';
import zlib from 'zlib';
import readline from 'readline';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ async function run() {
// lineNumber += 1;
const e = JSON.parse(line);
if (e.vatID !== vatID) {
// eslint-disable-next-line no-continue
continue; // wrong vat, or not associated with any vat
}
console.log(`e:`, e.type);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-continue */
import fs from 'fs';
import zlib from 'zlib';
import readline from 'readline';
Expand Down
1 change: 0 additions & 1 deletion packages/SwingSet/src/liveslots/collectionManager.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-continue */
import { assert, details as X, q, Fail } from '@agoric/assert';
import {
zeroPad,
Expand Down
2 changes: 1 addition & 1 deletion packages/casting/src/follower-cosmjs.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference types="ses"/>
/* eslint-disable no-await-in-loop, no-continue, @jessie.js/no-nested-await */
/* eslint-disable no-await-in-loop, @jessie.js/no-nested-await */

import { E, Far } from '@endo/far';
import * as tendermint34 from '@cosmjs/tendermint-rpc';
Expand Down
1 change: 0 additions & 1 deletion packages/cosmic-swingset/src/kernel-stats.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ export function makeSlogCallbacks({ metricMeter, attributes = {} }) {
// Add to aggregated metering stats.
for (const [key, value] of Object.entries(meterUsage)) {
if (key === 'meterType') {
// eslint-disable-next-line no-continue
continue;
}
getGroupedRecorder(`swingset_meter_usage`, group, {
Expand Down
1 change: 0 additions & 1 deletion packages/deployment/scripts/crunch.mjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#! /usr/bin/env node
// crunch.mjs - crunch a kvstore trace file's writes into TSV

/* eslint-disable no-continue */
/* global process,Buffer */

import fs from 'fs';
Expand Down
4 changes: 1 addition & 3 deletions packages/deployment/src/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ const doInit =
// eslint-disable-next-line no-await-in-loop
const { PROVIDER } = await askProvider({ inquirer })(PROVIDERS);
if (!PROVIDER) {
// eslint-disable-next-line no-continue
continue;
}
provider = PROVIDERS[PROVIDER];
Expand Down Expand Up @@ -400,7 +399,6 @@ const doInit =
myDetails,
);
if (CANCEL) {
// eslint-disable-next-line no-continue
continue;
}
// Out with the old, in with the new.
Expand Down Expand Up @@ -504,7 +502,7 @@ const doInit =

if (instance === offset) {
// No nodes added.
// eslint-disable-next-line no-continue

continue;
}

Expand Down
2 changes: 0 additions & 2 deletions packages/deployment/src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,6 @@ ${chalk.yellow.bold(`ag-setup-solo --netconfig='${dwebHost}/network-config'`)}
let sep = '';
for (const CLUSTER of Object.keys(prov.public_ips.value)) {
if (!isPublicRpc(prov.roles.value, CLUSTER)) {
// eslint-disable-next-line no-continue
continue;
}
const ips = prov.public_ips.value[CLUSTER];
Expand Down Expand Up @@ -781,7 +780,6 @@ ${chalk.yellow.bold(`ag-setup-solo --netconfig='${dwebHost}/network-config'`)}

for (const CLUSTER of Object.keys(prov.public_ips.value)) {
if (!selector(CLUSTER)) {
// eslint-disable-next-line no-continue
continue;
}
const ips = prov.public_ips.value[CLUSTER];
Expand Down
2 changes: 1 addition & 1 deletion packages/solo/src/outbound.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function deliver(mbs) {
for (const target of Object.getOwnPropertyNames(data)) {
if (!knownTargets.has(target)) {
log.error(`eek, no delivery method for target`, target);
// eslint-disable-next-line no-continue

continue;
}
const t = knownTargets.get(target);
Expand Down
1 change: 0 additions & 1 deletion packages/swingset-runner/src/push-metrics.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ function gatherMetrics(kind, data, labels, specs) {
const todo = new Set(Object.keys(data));
for (const { key, name } of KERNEL_STATS_METRICS) {
if (!(key in data)) {
// eslint-disable-next-line no-continue
continue;
}
todo.delete(key);
Expand Down
1 change: 0 additions & 1 deletion packages/telemetry/src/frcat-entrypoint.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const main = async () => {
process.stdout.write(bufStr);
}
if (process.stdout.write('\n')) {
// eslint-disable-next-line no-continue
continue;
}

Expand Down
1 change: 0 additions & 1 deletion packages/vats/src/authorityViz.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-continue */
// @ts-check
import '@endo/init';
import process from 'process';
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"eslintConfig": {
"extends": [
"@open-wc",
"@endo"
"@agoric"
],
"rules": {
"import/no-extraneous-dependencies": "off",
Expand Down
3 changes: 1 addition & 2 deletions packages/xsnap/src/avaXS.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ async function runTestScript(

for (const name of testNames) {
if (titleMatch && !isMatch(name, titleMatch)) {
// eslint-disable-next-line no-continue
continue;
}
assertionStatus = { ok: 0, 'not ok': 0, SKIP: 0 };
Expand Down Expand Up @@ -357,7 +356,7 @@ export async function main(
for (const filename of files) {
if (exclude && exclude.filter(s => filename.match(s)).length > 0) {
console.warn('# SKIP test excluded on XS', filename);
// eslint-disable-next-line no-continue

continue;
} else if (verbose) {
console.log('# test script:', filename);
Expand Down
2 changes: 0 additions & 2 deletions packages/xsnap/src/object-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -497,11 +497,9 @@ function arrObjKeys(obj, inspect) {
const syms = getOwnPropertySymbols(obj);
for (const key of getOwnPropertyNames(obj)) {
if (!isEnumerable.call(obj, key)) {
// eslint-disable-next-line no-continue
continue;
}
if (isArr && String(Number(key)) === key && key < obj.length) {
// eslint-disable-next-line no-continue
continue;
}
if ($test.call(/[^\w$]/, key)) {
Expand Down