Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: prettier jsdoc for 'store' #8212

Merged
merged 1 commit into from
Aug 16, 2023
Merged

style: prettier jsdoc for 'store' #8212

merged 1 commit into from
Aug 16, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Aug 16, 2023

closes: #6125

Description

Formats per request,

* items). This is in service of allowing incremental transition to use of
* durable stores, to enable normal operation and testing when some stuff
* intended to eventually be durable has not yet been made durable. A store
* @typedef {object} StoreOptions Of the dimensions on which KeyedStores can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for sending you off on this chase. When I compare before and after in WebStorm, the tool seems to have improved its parsing, and both the old and new render just fine. If you want to leave these formatting changes as they were, that would be fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha. well it's better enough that I'll click teh green button

@turadg turadg enabled auto-merge August 16, 2023 22:30
@turadg turadg added this pull request to the merge queue Aug 16, 2023
Merged via the queue into master with commit de82c94 Aug 16, 2023
64 of 67 checks passed
@turadg turadg deleted the 6125-store-jsdoc branch August 16, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reformat doc comments in packages/store/src/types.js
2 participants