Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Prepare for better guard typing from endo #8220

Merged
merged 1 commit into from
Aug 30, 2023
Merged

refactor: Prepare for better guard typing from endo #8220

merged 1 commit into from
Aug 30, 2023

Conversation

erights
Copy link
Member

@erights erights commented Aug 18, 2023 •
edited
Loading

Prepare for endos with endojs/endo#1715 or endojs/endo#1712 , while still being compat with agoric-sdk's current endo dependencies.

See also #8212

@erights erights self-assigned this Aug 18, 2023
@erights erights force-pushed the markm-remove-migrated-defns branch 3 times, most recently from 9865679 to edc8f9f Compare August 22, 2023 02:45
@erights erights changed the base branch from master to markm-8231-interfaces-be-passable August 22, 2023 02:45
@erights erights changed the base branch from markm-8231-interfaces-be-passable to master August 28, 2023 06:03
@erights erights force-pushed the markm-remove-migrated-defns branch from edc8f9f to 153b2dd Compare August 28, 2023 06:04
@erights erights requested a review from turadg August 28, 2023 06:05
turadg
turadg reviewed Aug 28, 2023
View reviewed changes
packages/swingset-liveslots/src/virtualObjectManager.js Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/virtualObjectManager.js Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
packages/store/src/types.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-remove-migrated-defns branch from 153b2dd to cae7c56 Compare August 28, 2023 23:28
@erights erights changed the title refactor(store): Prepare for better guard typing from endo refactor: Prepare for better guard typing from endo Aug 28, 2023
erights
erights commented Aug 28, 2023
View reviewed changes
packages/store/src/types.js Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/virtualObjectManager.js Outdated Show resolved Hide resolved
packages/swingset-liveslots/src/virtualObjectManager.js Outdated Show resolved Hide resolved
packages/store/src/types.js Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
@erights erights requested a review from turadg August 28, 2023 23:51
@erights erights force-pushed the markm-remove-migrated-defns branch 3 times, most recently from 0d51906 to ae283eb Compare August 29, 2023 20:22
turadg
turadg approved these changes Aug 29, 2023
View reviewed changes
packages/store/src/types.js Show resolved Hide resolved
packages/swingset-liveslots/src/vatDataTypes.d.ts Outdated Show resolved Hide resolved
packages/vat-data/src/exo-utils.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-remove-migrated-defns branch from ae283eb to 8ec2f74 Compare August 29, 2023 23:32
@erights erights force-pushed the markm-remove-migrated-defns branch from 8ec2f74 to a35b833 Compare August 29, 2023 23:33
@erights erights added the automerge:rebase Automatically rebase updates, then merge label Aug 29, 2023
@mergify mergify bot merged commit 1289bc4 into master Aug 30, 2023
76 of 78 checks passed
@mergify mergify bot deleted the markm-remove-migrated-defns branch August 30, 2023 00:00
@mhofman mhofman mentioned this pull request Aug 30, 2023
Merged
@erights erights mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees

@erights erights

Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @turadg