Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert boot tests to .ts #8313

Merged
merged 14 commits into from
Sep 18, 2023
Merged

convert boot tests to .ts #8313

merged 14 commits into from
Sep 18, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 7, 2023

Description

Converts bootstrapTests to use .ts syntax.

To support running .ts in tests, it configures Ava in @agoric/boot to use the tsx loader. It also adds a Node option to suppress the warnings about using an experimental feature. There will always be some way to load TS files so whatever API changes are required by future versions of Node, we will adopt as we upgrade.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Developers should be informed. I think we covered that in a meeting today.

Testing Considerations

Tests per se

Upgrade Considerations

n/a

@turadg turadg force-pushed the ta/ts-tests branch 2 times, most recently from 48d7dcc to fbf6682 Compare September 15, 2023 23:06
@turadg turadg requested a review from dckc September 15, 2023 23:08
@turadg turadg changed the title spike: .ts for tests convert boot tests to .ts Sep 15, 2023
@turadg turadg marked this pull request as ready for review September 15, 2023 23:10
@turadg turadg requested a review from iomekam September 15, 2023 23:10
Copy link
Contributor

@iomekam iomekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Sep 18, 2023
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gather this is likely to facilitate upcoming tests for multiple collaterals.

@mergify mergify bot merged commit 376236d into master Sep 18, 2023
71 checks passed
@mergify mergify bot deleted the ta/ts-tests branch September 18, 2023 20:45
turadg added a commit that referenced this pull request Sep 19, 2023
#8313 changed supports module to .ts
@turadg turadg mentioned this pull request Sep 19, 2023
turadg added a commit that referenced this pull request Sep 19, 2023
#8313 changed supports module to .ts
anilhelvaci pushed a commit to Jorge-Lopes/agoric-sdk that referenced this pull request Feb 16, 2024
Agoric#8313 changed supports module to .ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants