refactor(ertp): reallyPrepareIssuerKit #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Nov 6, 2023
erights
force-pushed
the
markm-really-prepare-issuer-kit
branch
from
45d94ee
to
71cf064
Compare
14 tasks
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8418
Description
Extracts from #8418 just the pure refactoring, especially around deprecating the badly named
prepareIssuerKit.Security Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no security implications.
Scaling Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no scaling implications.
Documentation Considerations
Following this PR, once we ensure that there are no used of the now-deprecated
prepareIssuerKit, we should renamereallyPrepareIssuerKittoprepareIssuerKit. Hopefully, we can complete that rename before bothering to document this API change.Testing Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no testing implications.
Upgrade Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should MOSTLY have no upgrade implications.
This PR also copes with the discovery that some state explicitly stored in baggage was redundant with other state implicitly stored in baggage. Rather than perpetuate the accidental redundancy, this PR merely ensures that it this redundancy is still there, that it is consistent, i.e., genuinely redundant as expected.
See the changes to feeMint.js and makeInvitation.js