Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare updates for Upgrade 15 #8868

Closed
14 tasks done
Chris-Hibbert opened this issue Feb 7, 2024 · 5 comments · Fixed by #9283
Closed
14 tasks done

prepare updates for Upgrade 15 #8868

Chris-Hibbert opened this issue Feb 7, 2024 · 5 comments · Fixed by #9283
Assignees
Labels
auction contract-upgrade enhancement New feature or request resource-exhaustion Threats to availability from resource exhaustion attacks Vaults VaultFactor (née Treasury) Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Feb 7, 2024

What is the Problem Being Solved?

A plan for the userland updates for Upgrade 15

Steps (in order)

  1. Zoe
  1. Price Feeds. (see Plan for replacing priceFeeds, redirecting oracles #8740)
  1. Auction
  1. Vaults

We decided (2/12) to upgrade from master rather than a branch, so it's not necessary to make branches. We still need the coreEvals.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Zoe package: Zoe resource-exhaustion Threats to availability from resource exhaustion attacks contract-upgrade Vaults VaultFactor (née Treasury) auction labels Feb 7, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Feb 7, 2024
@Chris-Hibbert
Copy link
Contributor Author

@turadg pointed out the seat created in upgrade-10 should still be live, and can be inspected to verify that the seat was fixed by 8682

@dckc
Copy link
Member

dckc commented Mar 13, 2024

I don't see #8123 in this plan. Is that on purpose?

@anilhelvaci Anil is doing some work on vault stuff and noticed that vaults do, in fact, lose the state of their governed parameters on upgrade.

@Chris-Hibbert
Copy link
Contributor Author

I don't see #8123 in this plan. Is that on purpose?

Yes.
It was never included in lists of goals that I saw. AIR, We explicitly decided to deal with the consequences of non-persistent governance.

@dckc
Copy link
Member

dckc commented Apr 29, 2024

We decided (2/12) to upgrade from master rather than a branch ...

That's now reified as:

perhaps that should go in the task list here?

@Chris-Hibbert
Copy link
Contributor Author

Last I heard, we were not planning to do any of the actually planned upgrades from master, but getting there is somewhere between a goal and a pious hope. I'm pretty sure something called upgrade 15 will go out without being pulled direct from master.

I think the things on this list are closer to upgrade 17 at this point, and so it's possible we'll include @9252, but I wouldn't consider it gating.

@mergify mergify bot closed this as completed in #9283 May 6, 2024
@mergify mergify bot closed this as completed in 24f7f32 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auction contract-upgrade enhancement New feature or request resource-exhaustion Threats to availability from resource exhaustion attacks Vaults VaultFactor (née Treasury) Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants