feat: when zcfSeats exit or fail, delete objects holding cycles #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in zcfSeat.js: zcfSeatToSeatHandle.delete(self) in exit.js: state.zccfSeat = undefined
Chris-Hibbert
added
Zoe
erights
approved these changes
Dec 30, 2023
Chris-Hibbert
added a commit
that referenced
this pull request
Jan 2, 2024
in zcfSeat.js: zcfSeatToSeatHandle.delete(self) in exit.js: state.zccfSeat = undefined
14 tasks
Chris-Hibbert
added a commit
that referenced
this pull request
Feb 28, 2024
in zcfSeat.js: zcfSeatToSeatHandle.delete(self) in exit.js: state.zccfSeat = undefined
Chris-Hibbert
added a commit
that referenced
this pull request
Feb 28, 2024
in zcfSeat.js: zcfSeatToSeatHandle.delete(self) in exit.js: state.zccfSeat = undefined
Chris-Hibbert
added a commit
that referenced
this pull request
Mar 1, 2024
in zcfSeat.js: zcfSeatToSeatHandle.delete(self) in exit.js: state.zccfSeat = undefined
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8401
refs: #8672
refs: #8682
Description
Drop cyclic references to zcfSeats and seatHandles when seats exit so GC can collect more cycles.
in zcfSeat.js: zcfSeatToSeatHandle.delete(self)
in exit.js: state.zccfSeat = undefined
Security Considerations
N/A
Scaling Considerations
Vast improvement in reducing retained garbage.
Documentation Considerations
Not visible to users
Testing Considerations
No tests added. It would be very hard to demonstrate freed objects in a test.
Upgrade Considerations
This is intended to be part of a fairly large collection of updates to Zoe/ZCF.