Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When setting a new zcfBundleCap, store it in baggage #8807

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #8806

Description

Copy of #8806 for the upgrade-15 release branch

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

As we're testing zoe upgrades in a3p, verify that the newly set value survives zoe upgrade.

Upgrade Considerations

Prep it for upgrade.

@Chris-Hibbert Chris-Hibbert added the Zoe package: Zoe label Jan 24, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Jan 24, 2024
@mhofman mhofman force-pushed the 8805-zoeSaveZcfBundle-upgrade15 branch from b6cc93e to e9e2da6 Compare January 31, 2024 22:44
Base automatically changed from 7918-upgrade15-updateZoeZcf to dev-upgrade-14 February 8, 2024 02:48
@mhofman mhofman force-pushed the 8805-zoeSaveZcfBundle-upgrade15 branch from e9e2da6 to 26f2999 Compare February 8, 2024 02:49
@mhofman mhofman added the force:integration Force integration tests to run on PR label Feb 8, 2024
@mhofman
Copy link
Member

mhofman commented Feb 8, 2024

@Chris-Hibbert it looks like the zoe.js part of the change from https://github.com/Agoric/agoric-sdk/pull/8806/files#diff-0a3a93511513efa0de6a26ae9a7e399dbcfca5adb2d71bd96245382fef8f2500 is not included here. Any reason why?

@Chris-Hibbert
Copy link
Contributor Author

it looks like the zoe.js part of the change from https://github.com/Agoric/agoric-sdk/pull/8806/files#diff-0a3a93511513efa0de6a26ae9a7e399dbcfca5adb2d71bd96245382fef8f2500 is not included here. Any reason why?

That's definitely either an oversight or just a bad merge. Those changes should be included here.

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are missing in the rebase.

@Chris-Hibbert
Copy link
Contributor Author

Some changes are missing in the rebase.

Thanks for catching this. I added the missing commit.

@Chris-Hibbert Chris-Hibbert mentioned this pull request Feb 8, 2024
14 tasks
@mhofman mhofman merged commit 8be87aa into dev-upgrade-14 Feb 8, 2024
63 checks passed
@mhofman mhofman deleted the 8805-zoeSaveZcfBundle-upgrade15 branch February 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants