chore: fix remaining lint issues (#9632) #9969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #9965 Fixed the following two issues: 1. packages/inter-protocol/src/proposals/startPSM.js 351:1 warning Expected JSDoc block to be aligned jsdoc/check-alignment - factored out typedef from the type cast so the cast is now a single-line comment. 2. packages/agoric-cli/test/inter-cli.test.js 255:1 warning `test.todo()` should not be used ava/no-todo-test 361:1 warning `test.todo()` should not be used ava/no-todo-test 419:1 warning `test.todo()` should not be used ava/no-todo-test 610:1 warning `test.todo()` should not be used ava/no-todo-test 620:1 warning `test.todo()` should not be used ava/no-todo-test 622:1 warning `test.todo()` should not be used ava/no-todo-test 628:1 warning `test.todo()` should not be used ava/no-todo-test - Opened a new issue #9965 to creare missing tests and commented out test.todo()'s None None. None. None: passed lint and type checker; actual code not affected. None.
turadg
reviewed
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9632
refs: #9965
Description
Fixed the following two issues:
test.todo()should not be used ava/no-todo-test 361:1 warningtest.todo()should not be used ava/no-todo-test 419:1 warningtest.todo()should not be used ava/no-todo-test 610:1 warningtest.todo()should not be used ava/no-todo-test 620:1 warningtest.todo()should not be used ava/no-todo-test 622:1 warningtest.todo()should not be used ava/no-todo-test 628:1 warningtest.todo()should not be used ava/no-todo-testSecurity Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None: passed lint and type checker; actual code not affected.
Upgrade Considerations
None.