chore (packages): Fix remaining lint issues (#9632) #9975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
I see the requests made in #9969 are done here.
In the future please don't make a new PR. It makes it much harder for the reviewer to regain context. Just push new commits to the same branch. Ideally as fixup! (see git autosquash) so that Mergify will amend the appropriate commits before they end up in master history.
siarhei-agoric
added
agoric-cli
gibson042
previously requested changes
Aug 27, 2024
Deploying agoric-sdk with
|
| Latest commit: |
b9c90aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c81f4c9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://sliakh-9632-fix-lint-2.agoric-sdk.pages.dev |
siarhei-agoric
dismissed
gibson042’s stale review
Slack discussion: moving TODOs into a separate issue is OK in this particular case.
|
@Mergifyio refresh |
✅ Pull request refreshed |
siarhei-agoric
force-pushed
the
sliakh-9632-fix_lint_2
branch
2 times, most recently
from
8f2a96e to
4c72b38
Compare
closes: #3632 refs: #9965 Fixed the following two issues: 1. packages/inter-protocol/src/proposals/startPSM.js 351:1 warning Expected JSDoc block to be aligned jsdoc/check-alignment - factored out typedef from the type cast so the cast is now a single-line comment. 2. packages/agoric-cli/test/inter-cli.test.js 255:1 warning `test.todo()` should not be used ava/no-todo-test 361:1 warning `test.todo()` should not be used ava/no-todo-test 419:1 warning `test.todo()` should not be used ava/no-todo-test 610:1 warning `test.todo()` should not be used ava/no-todo-test 620:1 warning `test.todo()` should not be used ava/no-todo-test 622:1 warning `test.todo()` should not be used ava/no-todo-test 628:1 warning `test.todo()` should not be used ava/no-todo-test - Opened a new issue #9965 to create missing tests and removed test.todo()
siarhei-agoric
force-pushed
the
sliakh-9632-fix_lint_2
branch
from
4c72b38 to
b9c90aa
Compare
gibson042
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9632
refs: #9965
Description
Fixed the following two issues:
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None: passed lint and type checker; actual code not affected.
Upgrade Considerations
None.