Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (packages): Fix remaining lint issues (#9632) #9975

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/agoric-cli/test/inter-cli.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ test('amount parsing', t => {
});
});

test.todo('want as max collateral wanted');

/**
* @type {import('@agoric/smart-wallet/src/offers.js').OfferStatus &
* { offerArgs: import('@agoric/inter-protocol/src/auction/auctionBook.js').OfferSpec}}
Expand Down Expand Up @@ -358,8 +356,6 @@ test('diagnostic for agd ENOENT', async t => {
t.is(out.join('').trim(), '');
});

test.todo('agd ENOENT clue outside normalizeAddress');

const usageTest = (words, blurb = 'Command usage:') => {
test(`Usage: ${words}`, async t => {
const argv = `node agops ${words} --help`.split(' ');
Expand Down Expand Up @@ -416,7 +412,6 @@ test('formatBid', t => {
}
});

test.todo('fmtBid with error does not show result');
/*
_not_ like this:
Expand Down Expand Up @@ -607,7 +602,6 @@ test('README ex1: inter bid place by-price: printed offer is correct', async t =
t.deepEqual(txt, expected);
});

test.todo('inter bid by-price shows tx, wallet status');
/*
$ agops inter bid by-price --price 0.81 --give 0.5 --maxBuy 3 --from gov2
2023-03-30T21:48:14.479332418Z not in block 49618 retrying...
Expand All @@ -617,12 +611,9 @@ first bid update:
{"id":"bid-1680212903989","price":"0.81 IST/ATOM","give":{"Bid":"0.5IST"},"want":"3ATOM","result":"Your bid has been accepted"}
*/

test.todo('execSwingsetTransaction returns non-0 code');

test.todo('already cancelled bid');
/*
$ agops inter bid cancel --from gov2 bid-1680211556497
bid-1680211556497 not in live offer ids: bid-1680211593489,bid-1680212903989,bid-1680213097499,bid-1680220217218,bid-1680220368714,bid-1680220406939
*/

test.todo('--give without number');
// TODO improve test coverage https://github.com/Agoric/agoric-sdk/issues/9965
siarhei-agoric marked this conversation as resolved.
Show resolved Hide resolved
24 changes: 14 additions & 10 deletions packages/inter-protocol/src/proposals/startPSM.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,18 +347,22 @@ export const makeAnchorAsset = async (
}),
);

const { creatorFacet: mint, publicFacet: issuer } = /**
* @type {{
/**
* @typedef {{
* creatorFacet: ERef<Mint<'nat'>>;
* publicFacet: ERef<Issuer<'nat'>>;
* }}
*/ (
await E(startUpgradable)({
installation: mintHolder,
label: keyword,
terms,
})
);
* }} PsmKit
*/

const { creatorFacet: mint, publicFacet: issuer } =
/** @type {PsmKit} */
(
await E(startUpgradable)({
installation: mintHolder,
label: keyword,
terms,
})
);
siarhei-agoric marked this conversation as resolved.
Show resolved Hide resolved

const brand = await E(issuer).getBrand();
const kit = harden({ mint, issuer, brand });
Expand Down
Loading