ci: restore yarn test, excluding e2e; restore node LTS

[dckc]

fixes #77

[0xpatrickdev]

Maybe better to stick this in the unit job? L23-L24

[dckc]

oops! yes, that's where I meant to put it...

p.s. I presume you don't mind a force push

[0xpatrickdev]

This doesn't look right either:

dapp-offer-up/.github/workflows/pr.yml

Lines 12 to 16 in 70540a2

	- name: Use Node.js 18.8.x
	uses: actions/setup-node@v3
	with:
	# use node 18.8.x until Agoric/agoric-sdk#8636
	node-version: "18.8.x"

, and Agoric/agoric-sdk#8636 is now closed. Maybe just 18.x, or ['18.x', '20.x'] since it's a quick job?

[dckc]

I'll try it, but see also

• Updated getting started guide to use Node v18.18.0 documentation#1065

[dckc]

(disabling auto-merge until Agoric/agoric-sdk#9250 lands)

[dckc]

odd... ci checks aren't running. I don't see why not.
clues, @rabi-siddique? @0xpatrickdev ?

[0xpatrickdev]

odd... ci checks aren't running. I don't see why not. clues, @rabi-siddique? @0xpatrickdev ?

I think we might need to do something like:

    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: ['18.x', '20.x']
    steps:
      - name: Checkout Repo
        uses: actions/checkout@v3
      - name: Use Node.js LTS versions
        uses: actions/setup-node@v3
        with:
          node-version: ${{ matrix.node-version }}

See https://github.com/Agoric/agoric-sdk/blob/c11fecbb0105bde2631adc14e106daf19c3f1201/.github/workflow-templates/test-dapp.yml#L9-L21

[amessbee]

@dckc can we merge this now?

[dckc]

@dckc can we merge this now?

It doesn't seem to work. I see Some checks haven’t completed yet and I don't see how to get them to complete.

If what you want is the change to node versions, you could make a PR with just that commit.

[amessbee]

@dckc Have you tried changing this to just a string instead of an array?
@frazarshad suggests:
"i think instead we can use matrix testing if we want to test on multiple node versions"

[dckc]

This was an attempt to do matrix testing. We should be testing on 18 and 20. Ah... it look like patrick's comment is saying roughly the same thing. I can try that...

[frazarshad]

@dckc @amessbee i think the CI checks arent passing because we've set unit as a required check for all PRs. but essentially we've replaced unit with unit (18) and unit (20) so thats why it cant pass that check.
can we try updating the required checks for this repo?