Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: restore yarn test, excluding e2e; restore node LTS #78

Merged
merged 3 commits into from
Aug 6, 2024
Merged

ci: restore yarn test, excluding e2e; restore node LTS #78

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5f64a9
ci: restore `yarn test`, excluding e2e
dckc Apr 18, 2024
65999e9
ci: use node LTS versions
dckc Apr 18, 2024
52f6751
fixup! ci: use node LTS versions
dckc Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@v3
- name: Use Node.js 18.8.x
- name: Use Node.js LTS versions
uses: actions/setup-node@v3
with:
# use node 18.8.x until Agoric/agoric-sdk#8636
node-version: "18.8.x"
node-version: ['18.x', '20.x']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dckc Have you tried changing this to just a string instead of an array?
@frazarshad suggests:
"i think instead we can use matrix testing if we want to test on multiple node versions"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an attempt to do matrix testing. We should be testing on 18 and 20. Ah... it look like patrick's comment is saying roughly the same thing. I can try that...

- name: yarn install
run: yarn
- name: yarn lint
run: yarn lint
- name: yarn build
run: yarn build
- name: yarn test
run: yarn test --exclude "**/e2e/**"
integration:
runs-on: ubuntu-latest
steps:
Expand Down