Make runner compatible with wide range of SDK revisions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Nov 25, 2021
runner/lib/tasks/local-chain.js
Outdated
| await fs.stat(name); | ||
| return true; | ||
| } catch (e) { | ||
| return false; |
There was a problem hiding this comment.
I would mildly prefer:
Suggested change
| return false; | |
| if (e.code === 'ENOENT') { | |
| return false; | |
| } | |
| throw e; |
There was a problem hiding this comment.
Agreed, but to be fair this is ripped straight from agoric-cli:
mhofman
force-pushed
the
mhofman/runner-compat-fixes
branch
from
bc973f6 to
6b1e31e
Compare
mhofman
force-pushed
the
mhofman/add-stats
branch
from
4d96e29 to
541e6a8
Compare
mhofman
force-pushed
the
mhofman/runner-compat-fixes
branch
2 times, most recently
from
b2b3005 to
dbf3f59
Compare
mhofman
force-pushed
the
mhofman/add-stats
branch
from
541e6a8 to
6ff64f6
Compare
Base automatically changed from
mhofman/add-stats
to
mhofman/preliminary-runner-refactors
January 17, 2022 21:59
mhofman
changed the base branch from
mhofman/preliminary-runner-refactors
to
main
mhofman
force-pushed
the
mhofman/runner-compat-fixes
branch
from
dbf3f59 to
1e66f9e
Compare
|
@michaelfig I addressed your feedback in ec62441 and made a small further change in 1e66f9e. Will carry your previous approval, squash and merge. |
mhofman
force-pushed
the
mhofman/runner-compat-fixes
branch
from
1e66f9e to
2e870bc
Compare
add devnet profile and shared save-storage options
Do not set loadgen config if no active loadgen requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started regenerating the corpus of stats, I realized that the runner and loadgen did not run correctly against both older and newer SDK revisions (I was working against a somewhat outdated version).
In particular:
The first issue is fixed by provisioning and starting the local-solo manually, which required hooking into the cli to figure out the right path to use across revisions.
The second issue is addressed by winding down the loadgen before shutting everything down. The issue has since been fixed in the agoric-sdk (Agoric/agoric-sdk#4116), but the workaround is left for older revisions, and is made configurable if we want to test for regressions.
For the last issue, the default config moves the wallet and loadgen deployments to stage 0, which is now truly a full setup stage.
As always, best reviewed commit-by-commit.
Stacks on top of the stats work (#36).