Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to return API response or download labels on checkout #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dahoo
Copy link

@dahoo dahoo commented Mar 29, 2019

Thanks for your work! It works great for us apart from the fact that we'd like to store the tracking code.

I added a download_labels parameter to checkout! to decide whether you want the old behavior or return the response with additional information.

@PatrickFranken
Copy link
Member

PatrickFranken commented Apr 2, 2019

Had to figure out first how my initial code actually worked after years not working on it 😆

Could you give an example output of "data" (L46)? I guess it would make sense to explain other developers a bit which data is returned. Right now it's just a basic PDF, missing any way of misinterpretation but that's obviously different with an hash.
Maybe just add an example to the README which gives an idea about what to receive if download_labels is false.

Anyway, thanks for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants