Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RecycleScroller): gridItems is undefined when scrollToItem, fix #773 #761

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

crs38c28
Copy link
Contributor

Description

Fix RecycleScroller scrollToItem method when itemSize is not null.  
Scroll position is wrong because gridItems is undefined.

Reproduction
Demo site

1. unchecked 'variable height'
2. click 'Scroll To:' button
3. list scroll to 'item 0' (not 'item 100')

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for vue-virtual-scroller-demo ready!

Name Link
🔨 Latest commit aefa009
🔍 Latest deploy log https://app.netlify.com/sites/vue-virtual-scroller-demo/deploys/63579a94fbe9e4000841b88b
😎 Deploy Preview https://deploy-preview-761--vue-virtual-scroller-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mjclyde
Copy link

mjclyde commented Oct 26, 2022

I just noticed this issue, made the same fix for it, then noticed your PR. 👍🏻 Nice catch.

@Akryum Akryum changed the title fix(RecycleScroller): gridItems is undefined when scrollToItem fix(RecycleScroller): gridItems is undefined when scrollToItem, fix #773 Dec 14, 2022
@Akryum Akryum merged commit 7c809ad into Akryum:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants