Workflow history scrolling issue

[kotcrab]

I have scrolling issue on workflow history page after updating from 3.31.0 to 3.35.4. The problem is that after clicking any history item, the history list disappears. After checking with devtools I see the scroller div height got changed to 0px:

Resizing the browser window causes this height to be updated and then it's set to some correct value:

This happens on both compact and grid view modes. Closing activity details pane also causes height to be 0px and then another window resize is needed to fix it.

I see that this 0px height is set on the component here but I'm not sure why it's done this way. I found PR #624 and then tried version 3.35.5-beta.2 but the issue is still there unfortunately.

I tested it on latest Chrome and Firefox and the issue is on both browsers.

[Assem-Uber]

Hi @kotcrab,
I would expect that the version of vue-virtual-scroller changed in your installation.
Can you provide the package version from your package-lock.json, if it is not 1.0.10 then changing it can be the fix.

[kotcrab]

Thanks for the quick response @Assem-Uber. We didn't have package-lock.json which I've corrected now. I checked and vue-virtual-scroller version 1.0.10 is installed (using cadence-web 3.35.5-beta.2), unfortunately this didn't fix this issue.

[kotcrab]

Could it be this issue Akryum/vue-virtual-scroller#757? Perhaps requiring fixed version 1.0.10 was a mistake and this issue is fixed in newer vue-virtual-scroller releases.

[adhityamamallan]

Our lockfile has always used v1.0.10, we locked the version in package.json to fix another bug that was caused by vue-virtual-scroller 1.1.2.

It's possible that a dependency of 1.0.10 is causing this issue; I'm investigating this.

[adhityamamallan]

Hey, so after some investigation, we were able to replicate the issue by using scrollparent 2.1.0. scrollparent ^2.0.1 is a dependency of vue-virtual-scroller, and while we have it locked at 2.0.1 in our lockfile, installing cadence-web as an NPM package means the lockfile doesn't come along with it, so it installs 2.1.0 by default.

Upgrading vue-virtual-scroller to 1.1.2 fixes the history list disappearing (even with scrollparent 2.1.0), but it introduces another issue (Akryum/vue-virtual-scroller#773) where clicking on any item in the history list causes the list to snap back to the beginning. Unfortunately, the fix for this was released in vue-virtual-scroller v2.0.0-beta.6, and we do not want to perform a major version update, especially to a beta release.

We've raised a PR to lock the version of scrollparent to 2.0.1 in package.json.

[adhityamamallan]

@kotcrab @matteeos I've added a version 3.35.5-beta.3 that should fix the issue, please try it out and let me know if the problem is solved.

[kotcrab]

Thanks @adhityamamallan I tried upgrading to beta.3 but unfortunately the issue still happens for us. I checked on the server to make sure the correct versions were installed:

/usr/app/node_modules # cat scrollparent/package.json | grep \"version\"
  "version": "2.0.1",
/usr/app/node_modules # cat vue-virtual-scroller/package.json | grep \"version\"
  "version": "1.0.10",

[adhityamamallan]

@kotcrab we've added an npm-shrinkwrap file and made a new release: 3.35.5-beta.4. Try this one out and let us know if it works 🤞🏾

[kotcrab]

It's now working correctly with beta.4. I guess it must be some other mismatched dependency version causing this issue. Thank you for the really quick help with this.

[adhityamamallan]

Glad to hear your issue's been resolved; have a good weekend!