Add scrollparent 2.0.1 dev dependency #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assem-Uber
force-pushed
the
scrollparent
branch
from
764f2d0 to
f67d798
Compare
Assem-Uber
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - locking scrollparent version at 2.0.1 as a quick fix for #632
The library vue-virtual-scroller 1.0.10 has some issues with scrollparent 2.1.0, which is the latest compatible version that gets automatically installed when cadence-web is used as an NPM package (and thus, the lockfile is absent).
Upgrading to vue-virtual-scroller's latest stable release 1.1.2 would fix this problem, but doing so introduces a bug with the history scroller where the autoscroll breaks, snapping the history view all the way up whenever any history event is selected. (more context: #624)
Fixing the snap-up issue with vue-virtual-scroller 1.1.2 would need us to rewrite a large portion of the History side panel code, so we are downgrading scrollparent as a quick fix for the issue.