Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy es5 bundling resources #31

Closed
blackfalcon opened this issue May 25, 2023 · 0 comments · Fixed by #38
Closed

Remove legacy es5 bundling resources #31

blackfalcon opened this issue May 25, 2023 · 0 comments · Fixed by #38
Assignees
@irma-kurnia-alaska
Labels
auro-alert
Milestone
Alert: Node 18+ U...

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Please delete any _legacy directory if one exists.

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

See linked commits for update references.

This issue was copied from #61 by @blackfalcon.

This issue was copied from #56 by @blackfalcon.
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label May 25, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 25, 2023
@blackfalcon blackfalcon added auro-alert Type: perf and removed Status: Work In Progress Issue or Pull Request work is in Progress labels May 25, 2023
@blackfalcon blackfalcon added this to the Node 18+ Update milestone May 25, 2023
@irma-kurnia-alaska irma-kurnia-alaska self-assigned this May 29, 2023
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue May 30, 2023
Merged
3 tasks
@irma-kurnia-alaska irma-kurnia-alaska linked a pull request May 30, 2023 that will close this issue
Update Node 18 #38
Merged
3 tasks
irma-kurnia-alaska pushed a commit that referenced this issue May 30, 2023
@irma-kurnia-phtn
perf: remove legacy es5 bundling resources #31
a27ecb8 
Change to be committed:
deleted: babel.config.js
deleted: index.html
modified: package-lock.json
modified: package.json
deleted: rollup.config.js
new file: rollup.config.mjs
deleted: src/es5.js
blackfalcon pushed a commit that referenced this issue Jun 29, 2023
@irma-kurnia-phtn @blackfalcon
perf: remove legacy es5 bundling resources #31
6c5b43a 
Change to be committed:
deleted: babel.config.js
deleted: index.html
modified: package-lock.json
modified: package.json
deleted: rollup.config.js
new file: rollup.config.mjs
deleted: src/es5.js
blackfalcon pushed a commit that referenced this issue Jun 29, 2023
@semantic-release-bot
chore(release): 2.0.4 [skip ci]
d799d8a 
## [2.0.4](v2.0.3...v2.0.4) (2023-06-29)

### Performance Improvements

* **deps:** remove unsed dependencies from project ([ab67636](ab67636))
* fix general feedback ([1c70c07](1c70c07))
* remove legacy es5 bundling resources [#31](#31) ([6c5b43a](6c5b43a))
* update to Lit2.0, TS support, issue templates, component registration extension [#32](#32) and update all depedencies legacy [#34](#34) ([c52ee38](c52ee38))
* update to node 18 [#33](#33) ([216ab80](216ab80))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-alert
Projects
None yet
Milestone
Alert: Node 18+ Updates
Development

Successfully merging a pull request may close this issue.

Update Node 18 AlaskaAirlines/auro-alert
2 participants
@blackfalcon @irma-kurnia-alaska