Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy es5 bundling resources #56

Closed
blackfalcon opened this issue Apr 21, 2023 · 7 comments · Fixed by #64
Closed

Remove legacy es5 bundling resources #56

blackfalcon opened this issue Apr 21, 2023 · 7 comments · Fixed by #64
Assignees
@fajar-apri-alaska
Labels
auro-flight Status: Work In Progress Issue or Pull Request work is in Progress Type: Perf Performance update to existing code
Milestone
Node 18+ update

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Apr 21, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Please delete any _legacy directory if one exists.

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

See linked commits for update references.

This issue was copied from #61 by @blackfalcon.
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress and removed Status: Work In Progress Issue or Pull Request work is in Progress labels Apr 21, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-header Apr 21, 2023
@blackfalcon blackfalcon added auro-flight Type: Perf Performance update to existing code labels Apr 21, 2023
@blackfalcon blackfalcon added this to the Node 18+ update milestone Apr 21, 2023
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue Apr 24, 2023
Closed
@fajar-apri-alaska fajar-apri-alaska self-assigned this Apr 25, 2023
@fajar-apri-alaska fajar-apri-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label Apr 25, 2023
fajar-apri-alaska added a commit that referenced this issue Apr 25, 2023
@fajar-apri-alaska
perf(es5): Remove legacy es5 bundling resources #56
3b79a8c 
Changes to be committed:
	modified:   README.md
	deleted:    _legacy/README.md
	deleted:    _legacy/package.json
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
fajar-apri-alaska added a commit that referenced this issue Apr 25, 2023
@fajar-apri-alaska
perf(es5): Remove legacy es5 bundling resources #56
d65fc1a 
Changes to be committed:
	modified:   .npmignore
	modified:   README.md
	deleted:    _legacy/README.md
	deleted:    _legacy/package.json
	deleted:    babel.config.js
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Apr 25, 2023
Merged
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Apr 25, 2023 that will close this issue
Node 18+ updates #6 #64
Merged
3 tasks
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 4, 2023
Closed
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 4, 2023
Closed
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 4, 2023
Closed
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 4, 2023
Closed
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 25, 2023
Closed
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue May 25, 2023
Closed
fajar-apri-alaska added a commit that referenced this issue Aug 7, 2023
@fajar-apri-alaska
perf(es5): Remove legacy es5 bundling resources #56
ccbe714 
Changes to be committed:
	modified:   .npmignore
	modified:   README.md
	deleted:    _legacy/README.md
	deleted:    _legacy/package.json
	deleted:    babel.config.js
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
blackfalcon pushed a commit that referenced this issue Aug 10, 2023
@fajar-apri-alaska @blackfalcon
perf: remove legacy processes, update to Lit2.0
cf964d0 
This commit addresses the following issues:

- Remove legacy es5 bundling resources #56
- update to Lit2.0 #57

Changes to be committed:
modified:   .npmignore
modified:   README.md
deleted:    _legacy/README.md
deleted:    _legacy/package.json
deleted:    babel.config.js
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
deleted:    rollup.config.js
new file:   rollup.config.mjs
modified:   scripts/staticStyles-template.js
modified:   src/auro-flight-header.js
modified:   src/auro-flight-main.js
modified:   src/auro-flight.js
blackfalcon pushed a commit that referenced this issue Aug 16, 2023
@fajar-apri-alaska @blackfalcon
perf: remove legacy processes, update to Lit2.0
9f020c8 
This commit addresses the following issues:

- Remove legacy es5 bundling resources #56
- update to Lit2.0 #57

Changes to be committed:
modified:   .npmignore
modified:   README.md
deleted:    _legacy/README.md
deleted:    _legacy/package.json
deleted:    babel.config.js
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
deleted:    rollup.config.js
new file:   rollup.config.mjs
modified:   scripts/staticStyles-template.js
modified:   src/auro-flight-header.js
modified:   src/auro-flight-main.js
modified:   src/auro-flight.js
blackfalcon pushed a commit that referenced this issue Aug 16, 2023
@semantic-release-bot
chore(release): 2.4.0 [skip ci]
4618178 
# [2.4.0](v2.3.0...v2.4.0) (2023-08-16)

### Features

* **node18:** address updated resources [#57](#57), [#58](#58) ([9f09da1](9f09da1))

### Performance Improvements

* remove legacy processes, update to Lit2.0 ([9f020c8](9f020c8)), closes [#56](#56) [#57](#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

Labels
auro-flight Status: Work In Progress Issue or Pull Request work is in Progress Type: Perf Performance update to existing code
Projects
None yet
Milestone
Node 18+ update
Development

Successfully merging a pull request may close this issue.

Node 18+ updates #6 AlaskaAirlines/auro-flight
2 participants
@blackfalcon @fajar-apri-alaska