Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy es5 bundling resources #188

Closed
blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #192
Closed

Remove legacy es5 bundling resources #188

blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #192
Assignees
@irma-kurnia-alaska
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Perf Performance update to existing code
Milestone
Node 18+ update

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Please delete any _legacy directory if one exists.

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

See linked commits for update references.

This issue was copied from #61 by @blackfalcon.

This issue was copied from #56 by @blackfalcon.
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress Type: Perf Performance update to existing code labels May 4, 2023
@blackfalcon blackfalcon added this to the Node 18+ update milestone May 4, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 4, 2023
@blackfalcon blackfalcon added auro-combobox and removed Status: Work In Progress Issue or Pull Request work is in Progress labels May 4, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label May 5, 2023
irma-kurnia-alaska pushed a commit that referenced this issue May 5, 2023
@irma-kurnia-phtn
perf(es5): remove legacy es5 bundling resources #188
d2511bb 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    index.html
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue May 5, 2023
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue May 24, 2023
@irma-kurnia-phtn @blackfalcon
perf(es5): remove legacy es5 bundling resources #188
00fc103 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    index.html
blackfalcon pushed a commit that referenced this issue May 24, 2023
@semantic-release-bot
chore(release): 2.9.8 [skip ci]
3edf8bf 
## [2.9.8](v2.9.7...v2.9.8) (2023-05-24)

### Performance Improvements

* **es5:** remove legacy es5 bundling resources [#188](#188) ([00fc103](00fc103))
* **husky:** update .husky/pre-commit and necessary pre-commit actions ([1dd87cc](1dd87cc))
* remove unused script ([6f13cd2](6f13cd2))
* update general feedback for update node 18 ([af2692e](af2692e))
* update to Lit2.0, TS support, issue templates, component registration extension and update to Node 18+ ([8432071](8432071))
* update webcorestylesheets from "@alaskaairux/webcorestylesheets": "^3.7.3" into "@aurodesignsystem/webcorestylesheets": "^4.2.0" ([5566dbf](5566dbf))
@blackfalcon
Copy link
Member Author

🎉 This issue has been resolved in version 2.9.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Perf Performance update to existing code
Projects
None yet
Milestone
Node 18+ update
Development

Successfully merging a pull request may close this issue.

Irmaku/update node18 AlaskaAirlines/auro-dropdown
2 participants
@blackfalcon @irma-kurnia-alaska