Irmaku/update node18 #192
Merged
Irmaku/update node18 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: README.md deleted: babel.config.js modified: package-lock.json modified: package.json deleted: rollup.config.js new file: rollup.config.mjs deleted: index.html
…ration extension and update to Node 18+ Change to be committed: modified: package-lock.json modified: package.json modified: README.md modified: .github/settings.yml modified: .github/workflows/testPublish.yml modified: .husky/pre-commit modified: scripts/staticStyles-template.js modified: src/auro-dropdown.js deleted: .github/ISSUE_TEMPLATE/bug_report.md deleted: .github/ISSUE_TEMPLATE/feature_request.md deleted: .github/ISSUE_TEMPLATE/general-support.md deleted: packageScripts/postinstall.js new file: tsconfig.json new file: .github/ISSUE_TEMPLATE/bug_report.yml new file: .github/ISSUE_TEMPLATE/feature_request.yml new file: .github/ISSUE_TEMPLATE/general-support.yml new file: packageScripts/postinstall.mjs
|
|
This was
linked to
issues
May 5, 2023
Closed
Changes to be committed: modified: .husky/pre-commit modified: package.json modified: scripts/postCss.js modified: src/style.scss modified: .stylelintrc deleted: scripts/removeNonRemPlugin.js deleted: src/style-fixed.scss
Change to be committed: modified: demo/index.html
Change to be committed: modified: package.json
blackfalcon
requested changes
May 16, 2023
| "build:api": "wca analyze 'src/auro-dropdown.js' --outFiles docs/api.md", | ||
| "build:demo": "npm-run-all build demo:rm:build demo:new:build demo:copy:index demo:copy:demo demo:update:index", | ||
| "build:dev:assets": "npm-run-all build:sass:demo build:sass:component postCss:component sass:render build:docs", | ||
| "build:markdownDocs": "node scripts/generateDocs.js", |
There was a problem hiding this comment.
Revert this removed script and update to the following.
"build:markdownDocs": "node scripts/generateDocs.js",
Change to be committed: modified: .stylelintrc modified: package-lock.json modified: package.json modified: .github/ISSUE_TEMPLATE/bug_report.yml modified: .husky/pre-commit modified: src/style.scss deleted: scripts/pre-commit.js new file: scripts/pre-commit.mjs
|
Hi @blackfalcon, I will updated as you mention feedback for this PR. Thank you for your feedback. |
…": "^3.7.3" into "@aurodesignsystem/webcorestylesheets": "^4.2.0" Change to be committed: modified: package-lock.json modified: package.json
Changes to be committed: modified: .gitignore deleted: docTemplates/README.md modified: .npmignore deleted: scripts/prepForBuild.js
blackfalcon
approved these changes
May 24, 2023
|
🎉 This PR is included in version 2.9.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #188 , #189 , #190 , #191
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team