Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #57

Closed
2 tasks
jordanjones243 opened this issue Mar 11, 2024 · 1 comment · Fixed by #60 or #61
Closed
2 tasks

Update color tokens for theming support #57

jordanjones243 opened this issue Mar 11, 2024 · 1 comment · Fixed by #60 or #61
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 11, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature Type: Question Type: Design New or related Design work not-reviewed Issue has not been reviewed by Auro team members auro-alert labels Mar 11, 2024
@jordanjones243
Copy link
Contributor Author

Tokens/Rules to be changed:

  • svg color rules (we need additional semanticly named icon colors for all states)
  • border-color rules are using incorrect semantic tokens

Tier 1 tokens:

  • border-color: var(--ds-color-brand-neutral-400, $ds-color-brand-neutral-400);

Background Color tokens:

  • background-color: var(--ds-color-background-lightest, $ds-color-background-lightest);

@jordanjones243 jordanjones243 linked a pull request Mar 14, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Jul 1, 2024
6 tasks
@jordanjones243 jordanjones243 linked a pull request Jul 1, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 2, 2024
# [2.2.0-beta.1](v2.1.8...v2.2.0-beta.1) (2024-07-02)

### Features

* **icon:** convert icons into auro-icons ([f6ea49b](f6ea49b))
* refactor color styles using tier 3 tokens [#57](#57) ([ef1b0ca](ef1b0ca))
@jordanjones243 jordanjones243 linked a pull request Aug 14, 2024 that will close this issue
6 tasks
jordanjones243 added a commit that referenced this issue Sep 24, 2024
BREAKING CHANGE: trigger major release for theming support #57
@jordanjones243 jordanjones243 mentioned this issue Sep 24, 2024
6 tasks
jordanjones243 added a commit that referenced this issue Sep 24, 2024
BREAKING CHANGE: trigger major release for theming support #57
blackfalcon pushed a commit that referenced this issue Sep 24, 2024
# [3.0.0-beta.1](v2.2.0-beta.2...v3.0.0-beta.1) (2024-09-24)

### Performance Improvements

* update dependencies ([5228a87](5228a87))

### BREAKING CHANGES

* trigger major release for theming support #57
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [2.2.0-beta.1](v2.1.8...v2.2.0-beta.1) (2024-07-02)

### Features

* **icon:** convert icons into auro-icons ([f6ea49b](f6ea49b))
* refactor color styles using tier 3 tokens [#57](#57) ([ef1b0ca](ef1b0ca))
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for theming support #57
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0-beta.1](v2.2.0-beta.2...v3.0.0-beta.1) (2024-09-24)

### Performance Improvements

* update dependencies ([5228a87](5228a87))

### BREAKING CHANGES

* trigger major release for theming support #57
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0](v2.1.8...v3.0.0) (2024-09-30)

### Features

* add tag name as attribute when custom reigstered ([1d03bdd](1d03bdd))
* **icon:** convert icons into auro-icons ([b890e39](b890e39))
* refactor color styles using tier 3 tokens [#57](#57) ([e378540](e378540))

### Performance Improvements

* refactor custom component registration config ([acd89e1](acd89e1))
* update dependencies ([50b6ec8](50b6ec8))
* update dependencies ([4700ecf](4700ecf))

### BREAKING CHANGES

* trigger major release for theming support #57
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
@jason-capsule42 jason-capsule42 removed Type: Question Type: Design New or related Design work not-reviewed Issue has not been reviewed by Auro team members labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment