Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #64

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update dependencies #64

merged 1 commit into from
Sep 24, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Sep 24, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update dependencies to newer versions, including design tokens and web core stylesheets, and adjust the icon version in the source code. This change triggers a major release for theming support.

Enhancements:

  • Update design tokens and web core stylesheets to newer versions in the README.

Chores:

  • Update the icon version in the source code.

BREAKING CHANGE: trigger major release for theming support #57
@jordanjones243 jordanjones243 self-assigned this Sep 24, 2024
Copy link

sourcery-ai bot commented Sep 24, 2024

Reviewer's Guide by Sourcery

This pull request updates dependencies and includes a breaking change for theming support. The main changes are updating the versions of design-tokens and webcorestylesheets in the README.md file, and updating the iconVersion in src/iconVersion.js.

File-Level Changes

Change Details Files
Update design-tokens and webcorestylesheets versions
  • Update design-tokens version from 4.3.1 to 4.9.2
  • Update webcorestylesheets version from 5.0.6 to 5.1.2
README.md
Update icon version
  • Change icon version from '5.0.0-beta.1' to an unspecified new version
src/iconVersion.js

Sequence Diagram

No sequence diagram generated.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 merged commit 5228a87 into beta Sep 24, 2024
3 checks passed
@jordanjones243 jordanjones243 deleted the jjones/updateDeps branch September 24, 2024 20:02
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more details about the nature of the breaking change mentioned in the PR title and how it affects the project.
  • The self-review checkbox in the PR template is not checked. Please ensure you've performed a self-review of your changes.
  • While design-tokens and webcorestylesheets have been updated in the README, the auro-alert script tag version remains unchanged. Is this intentional or does it also need to be updated?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants