Create rounded button #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This commit removes all legacy es6 build process including light-dom support, fixed CSS, non CSS variable support, and es5 bundling. Changes to be committed: modified: README.md deleted: babel.config.js deleted: demo/alert.js modified: demo/demo.md modified: demo/index.html deleted: demo/sass/style.scss deleted: index.html modified: package-lock.json modified: package.json modified: packageScripts/postinstall.js modified: rollup.config.js modified: scripts/postCss.js deleted: scripts/removeNonRemPlugin.js deleted: src/auro-button-light.js modified: src/auro-button.js deleted: src/es5.js deleted: src/style-fixed.scss deleted: src/style-ld.scss
BREAKING CHANGE: This commit will remove all support for ID attribute reflection from the parent element to the inner button element. Changes to be committed: modified: src/auro-button.js modified: test/auro-button.test.js modified: packageScripts/postinstall.js
Changes to be committed: modified: docs/api.md modified: package.json modified: src/auro-button.js modified: src/style.scss deleted: src/util.js
BREAKING CHANGE: This commit will remove all legacy support for placement of icons within the element other than supporting icons as slotted content. Changes to be committed: modified: docs/api.md modified: src/auro-button.js modified: src/style.scss
Changes to be committed: modified: docs/api.md modified: src/auro-button.js
This commit addresses the following updates. 1. Component registration 2. Typescript support 3. Lit.20 4. Husky 8.0 5. Dart-Sass 6. Update all resources to Node 18 7. Delete legacy Polymer support 8. Update to @open-wc/testing 9. Single CLI development support 10. Update to @AuroDesignSystem 11. Add CODEOWNER file 12. Update issue templates 13. Update repo settings 14. Update Chalk v5 and postintall script BREAKING CHANGE: This commit includes an update to the npm namespace to @AuroDesignSystem. Changes to be committed: new file: .github/CODEOWNERS deleted: .github/ISSUE_TEMPLATE/audit.md deleted: .github/ISSUE_TEMPLATE/bug_report.md new file: .github/ISSUE_TEMPLATE/bug_report.yml deleted: .github/ISSUE_TEMPLATE/develop-design-story.md deleted: .github/ISSUE_TEMPLATE/feature_request.md new file: .github/ISSUE_TEMPLATE/feature_request.yml deleted: .github/ISSUE_TEMPLATE/general-support.md new file: .github/ISSUE_TEMPLATE/general-support.yml deleted: .github/ISSUE_TEMPLATE/new_wc.md deleted: .github/ISSUE_TEMPLATE/parent-design-story.md deleted: .github/ISSUE_TEMPLATE/review-design-story.md deleted: .github/ISSUE_TEMPLATE/symbol-design-story.md deleted: .github/ISSUE_TEMPLATE/user-story.md modified: .github/settings.yml modified: .github/workflows/testPublish.yml modified: .gitignore new file: .husky/pre-commit modified: .npmignore modified: index.js deleted: karma.conf.js modified: package-lock.json
This update deprecates the use of secondary and tertiary UI as individual attributes and moves them to the appropriate enum attribute of `variant`. Changes to be committed: modified: demo/demo.md modified: docs/api.md modified: package.json modified: packageScripts/postinstall.mjs modified: src/auro-button.js modified: src/style.scss
This commit address an issue related to updated color spec for the button when placed on dark backgrounds. See design spec: https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?type=design&node-id=322-813&t=FqowZrMG1mtW6O1z-0 Changes to be committed: modified: src/style.scss
Changes to be committed: modified: package-lock.json modified: package.json
|
This PR is no longer valid and the work in this PR will be addressed here: #214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #212
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Create new
roundedbutton feature and add examples to docsite.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team