New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rounded button feature #214

Merged

jason-capsule42 merged 9 commits into master from jordanjones243/roundedButtonRedo/#212

Jul 11, 2023

Contributor

jordanjones243 commented Jun 6, 2023 •

edited by blackfalcon

Loading

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #212

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Create new rounded button feature and add examples to docsite.

Type of change:

Please delete options that are not relevant.

New capability
Revision of an existing capability
Infrastructure change (automation, etc.)
Other (please elaborate)

Checklist:

My update follows the CONTRIBUTING guidelines of this project
I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

jordanjones243 requested a review from a team as a code owner

June 6, 2023 17:49

jordanjones243 self-assigned this

jordanjones243 linked an issue

that may be closed by this pull request

auro-button: animated button shape #212

Closed

jordanjones243 mentioned this pull request

Create rounded button #213

Closed

6 tasks

jordanjones243 changed the title ~~Jordanjones243/rounded button redo/#212~~ Create rounded button feature

jason-capsule42 requested changes

View reviewed changes

Member

jason-capsule42 left a comment

In addition to the inline comments I am also getting a linting error when I run the build. The error is because we are linting ./src/*.css when I think we should only be doing ./src/*.scss.

demo/demo.md Outdated Show resolved Hide resolved

demo/demo.md Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

demo/index.html Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

docs/api.md Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

docs/api.md Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

src/auro-button.js Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

src/style.scss Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

src/style.scss Outdated Show resolved Hide resolved

jason-capsule42 reviewed

View reviewed changes

web-test-runner.config.mjs Outdated Show resolved Hide resolved

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch 3 times, most recently from 1de42c1 to 22ccfc2 Compare

June 7, 2023 22:10

jordanjones243 marked this pull request as draft

June 7, 2023 22:13

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch 5 times, most recently from 7ab3996 to fff941e Compare

June 8, 2023 19:06

jordanjones243 requested a review from jason-capsule42

June 8, 2023 19:06

jordanjones243 marked this pull request as ready for review

June 8, 2023 19:06

Izook reviewed

View reviewed changes

src/auro-button.js Outdated Show resolved Hide resolved

Izook reviewed

View reviewed changes

src/style.scss Outdated Show resolved Hide resolved

Izook reviewed

View reviewed changes

test/auro-button.test.js Show resolved Hide resolved

Izook reviewed

View reviewed changes

src/auro-button.js Outdated Show resolved Hide resolved

blackfalcon requested changes

View reviewed changes

src/style.scss Outdated Show resolved Hide resolved

src/style.scss Outdated Show resolved Hide resolved

src/style.scss Outdated Show resolved Hide resolved

src/style.scss Outdated Show resolved Hide resolved

src/style.scss Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

demo/index.min.js Outdated Show resolved Hide resolved

src/auro-button.js Outdated Show resolved Hide resolved

Izook reviewed

View reviewed changes

demo/api.min.js Show resolved Hide resolved


          docs(examples): implement example js system

2919f62

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch from dcfad45 to 7fd3867 Compare

June 20, 2023 20:02

blackfalcon requested changes

View reviewed changes

package.json Show resolved Hide resolved

jordanjones243 requested a review from blackfalcon

June 29, 2023 18:10

blackfalcon requested changes

View reviewed changes

apiExamples/icon.html Show resolved Hide resolved

blackfalcon self-requested a review

June 30, 2023 22:22

blackfalcon approved these changes

View reviewed changes

Member

blackfalcon left a comment

blackfalcon requested changes

View reviewed changes

Member

blackfalcon left a comment

The feature where you hover over a button and it shows content is not accessible.

The concept of hover is not accessible either. There needs to be audible feedback as to the content of the button on a tab interaction.

Screen Shot 2023-06-30 at 5 18 32 PM

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch 2 times, most recently from 6bc8ee7 to eec6a4b Compare

July 5, 2023 20:40

blackfalcon previously approved these changes

View reviewed changes

jordanjones243 dismissed blackfalcon’s stale review via

4a6a709

July 6, 2023 21:36

Izook reviewed

View reviewed changes

.stylelintrc Show resolved Hide resolved

Izook reviewed

View reviewed changes

src/style.scss Show resolved Hide resolved

jason-capsule42 requested changes

View reviewed changes

apiExamples/roundedRightAlign.html Outdated Show resolved Hide resolved

apiExamples/roundedRightAlign.js Show resolved Hide resolved

jordanjones243 and others added 4 commits

July 6, 2023 15:37


          docs(rounded): add examples for rounded button #212

3ba91aa


          docs(readme): add additional info to readme

9bbc324


          perf(stylelint): update to modern stylelint practices

046727f


          docs(readme): update content from build

9b6d01a

Changes to be committed:
modified:   README.md

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch from 4a6a709 to 86457a5 Compare

July 6, 2023 22:37


          fix(animation): fix hide/show text animation on rounded button

01c5795

jordanjones243 force-pushed the jordanjones243/roundedButtonRedo/#212 branch from 86457a5 to 01c5795 Compare

July 6, 2023 22:40

jordanjones243 requested a review from jason-capsule42

July 7, 2023 17:00


          build(deps): update dependencies

2ad901b

blackfalcon approved these changes

View reviewed changes

jason-capsule42 approved these changes

View reviewed changes

jason-capsule42 merged commit 8c78265 into master

jason-capsule42 deleted the jordanjones243/roundedButtonRedo/#212 branch

July 11, 2023 19:35

Member

blackfalcon commented Jul 11, 2023

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

blackfalcon added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels