Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-checkbox: Theming support #116

Closed
braven112 opened this issue Nov 1, 2023 · 2 comments · Fixed by #143
Closed

auro-checkbox: Theming support #116

braven112 opened this issue Nov 1, 2023 · 2 comments · Fixed by #143
Assignees
@blackfalcon @fajar-apri-alaska @Patrick-Daly-AA
Labels
auro-checkbox not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Nov 1, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
And this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
@braven112 braven112 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-checkbox labels Nov 1, 2023
fajar-apri-alaska added a commit that referenced this issue Nov 2, 2023
@fajar-apri-alaska
perf(token): update token per new theming #116
c1a05f6 
- also add scss fallback values
- keep old token npm package for the time being

Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/auro-checkbox-group.scss
	modified:   src/auro-checkbox.scss
	modified:   src/style.scss
@fajar-apri-alaska
Copy link

I think @blackfalcon is currently working on this issue in this PR.

@jason-capsule42
Copy link
Member

Closing this ticket and the work is done in the above liinked PR.

@jason-capsule42 jason-capsule42 linked a pull request Sep 23, 2024 that will close this issue
perf: update dependencies #143
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@fajar-apri-alaska fajar-apri-alaska

@Patrick-Daly-AA Patrick-Daly-AA

Labels
auro-checkbox not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: update dependencies AlaskaAirlines/auro-checkbox
5 participants
@blackfalcon @braven112 @jason-capsule42 @fajar-apri-alaska @Patrick-Daly-AA