Update CSS token per new design system theming capability #185
Conversation
src/style.scss
Outdated
| @@ -82,6 +83,7 @@ | |||
|
|
|||
| &--ondark { | |||
| &:hover { | |||
| // This somehow doesn't refer to anywhere | |||
| color: var(--auro-hyperlink-ondark-hover-color); | |||
There was a problem hiding this comment.
This new --ds- token doesn't exist.
We should figure out what the old token resolved to for the value and then find a token in the new DS tokens with the same value.
There was a problem hiding this comment.
Agree, and I'd love to do that. Problem is I couldn't find the old reference for --auro-hyperlink-ondark-hover-color.
Not sure if this token name refers to this figma, or there is custom token that specifically created for hyperlink only.
If it is, then maybe the real token name is --auro-color-text-primary-on-light or --ds-color-text-primary-default based on the blueprint.
Please advise, thank you.
There was a problem hiding this comment.
@leeejune can you help us figure out what token should be used here?
There was a problem hiding this comment.
The real token name for --auro-color-text-primary-on-light is --ds-color-text-primary-default. The -on-light has been converted to -default and -on-dark is now -inverse
There was a problem hiding this comment.
@fajar-apri-alaska talked with @leeejune directly and it seems we should go ahead and use --auro-color-ui-hover-on-dark here.
fajar-apri-alaska
force-pushed
the
fajarapri/updateCSSToken
branch
3 times, most recently
from
a8452e9 to
5a8b365
Compare
fajar-apri-alaska
force-pushed
the
fajarapri/updateCSSToken
branch
2 times, most recently
from
83053b0 to
a69c6ae
Compare
Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: src/style.scss
fajar-apri-alaska
force-pushed
the
fajarapri/updateCSSToken
branch
from
a69c6ae to
5c2b922
Compare
Changes to be committed: modified: src/style.scss
Changes to be committed: modified: package-lock.json modified: package.json
|
I have pushed a new commit per your feedback @jason-capsule42. Thanks. |
|
🎉 This PR is included in version 3.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Fixes: #183
Summary:
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team