Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-hyperlink: Theming support #183

Closed
braven112 opened this issue Sep 25, 2023 · 0 comments · Fixed by #185
Closed

auro-hyperlink: Theming support #183

braven112 opened this issue Sep 25, 2023 · 0 comments · Fixed by #185
Assignees
@fajar-apri-alaska @irma-kurnia-alaska
Labels
auro-hyperlink Type: Feature New Feature
Milestone
Theming

Comments

@braven112
Copy link
Member

braven112 commented Sep 25, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231

Exit criteria

All tokens referencing --auro have been updated.
Validate the changes after this work item is also complete #184
@braven112 braven112 added Type: Feature New Feature auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members labels Sep 25, 2023
@braven112 braven112 added this to the Theming milestone Sep 25, 2023
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 28, 2023
fajar-apri-alaska added a commit that referenced this issue Oct 2, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
fe2da66 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Oct 2, 2023
Merged
3 tasks
@blackfalcon blackfalcon linked a pull request Oct 2, 2023 that will close this issue
Update CSS token per new design system theming capability #185
Merged
3 tasks
fajar-apri-alaska added a commit that referenced this issue Oct 5, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
a8452e9 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
fajar-apri-alaska added a commit that referenced this issue Oct 5, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
5a8b365 
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
fajar-apri-alaska added a commit that referenced this issue Oct 6, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
83053b0 
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
fajar-apri-alaska added a commit that referenced this issue Oct 6, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
a69c6ae 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
fajar-apri-alaska added a commit that referenced this issue Oct 11, 2023
@fajar-apri-alaska
perf(token): update token per new theming #183
5c2b922 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
jason-capsule42 pushed a commit that referenced this issue Oct 30, 2023
@fajar-apri-alaska @jason-capsule42
perf(token): update token per new theming #183
79877ca 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
blackfalcon pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
chore(release): 3.3.7 [skip ci]
1f86814 
## [3.3.7](v3.3.6...v3.3.7) (2023-10-30)

### Performance Improvements

* add old design-tokens deps ([17fdaac](17fdaac))
* **token:** update token per new theming [#183](#183) ([79877ca](79877ca))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-hyperlink Type: Feature New Feature
Projects
None yet
Milestone
Theming
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability AlaskaAirlines/auro-hyperlink
5 participants
@blackfalcon @braven112 @fajar-apri-alaska @irma-kurnia-alaska @Patrick-Daly-AA