Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appears translucent in prod, needs to be filled with white #44

Closed
KaylaBlyton1 opened this issue Nov 4, 2021 · 5 comments · Fixed by #48
Closed

Appears translucent in prod, needs to be filled with white #44

KaylaBlyton1 opened this issue Nov 4, 2021 · 5 comments · Fixed by #48
Assignees
@blackfalcon
Labels
auro-checkbox Status: Review Needed Work is completed, user is requesting feedback Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@KaylaBlyton1
Copy link

Describe the bug

Auro-checkbox appears filled with white in designer files, but shows as translucent in prod. This means if a a background is grey, the inside of the checkbox will also appear grey - which appears as disabled to users.

To Reproduce

Steps to reproduce the behavior:
This error was found it flight stages, but its not in production. Its part of the microsite. Screenshots are below.

Expected behavior

Checkboxes should be filled with white for better visibility and clarity.

Screenshots

How it should look - filled
How it looks - transparent

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.
@braven112 braven112 transferred this issue from AlaskaAirlines/auro Nov 4, 2021
@braven112 braven112 mentioned this issue Nov 4, 2021
Closed
4 tasks
@braven112 braven112 added the not-reviewed Issue has not been reviewed by Auro team members label Nov 4, 2021
@braven112 braven112 added this to the v1.2-rc milestone Nov 4, 2021
@braven112 braven112 mentioned this issue Nov 4, 2021
Closed
2 tasks
@braven112
Copy link
Member

@KaylaBlyton1 @leeejune When a checkbox is in a disabled state what color should the background be? Still white or do we have a light grey color to use for that situation?

@braven112 braven112 changed the title auro-[checkbox]: [Appears translucent in prod, needs to be filled with white] auro-checkbox: Appears translucent in prod, needs to be filled with white Nov 4, 2021
@KaylaBlyton1
Copy link
Author

@braven112 Here is the blueprint (stealing from @leeejune!)

It looks like the box should be filled with "background/lightest" (aka white) in active, error, and disabled states.

https://www.figma.com/file/wU5lxm5roZpGkm6Af5w8a9/Checkbox?node-id=322%3A298

@blackfalcon blackfalcon removed their assignment Nov 4, 2021
@blackfalcon
Copy link
Member

@braven112 I'd suggest just releasing this as a bug. The blueprint is pretty clear as to what is missing.

@braven112
Copy link
Member

@blackfalcon That totally works for me. I created an RC but just to include this bug and the blueprint work. Are you suggesting that the RC's shouldn't include bugs or blueprint work and we can list those separately on the board? If so that sounds great to me.

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 8, 2021
@blackfalcon blackfalcon removed this from the v1.2-rc milestone Nov 8, 2021
@blackfalcon blackfalcon self-assigned this Nov 8, 2021
blackfalcon added a commit that referenced this issue Nov 8, 2021
@blackfalcon
fix(style): add background color to checkbox #44
c027176
@blackfalcon blackfalcon linked a pull request Nov 8, 2021 that will close this issue
Update UI of the checkbox element #48
Merged
6 tasks
@blackfalcon blackfalcon added Status: Proposal Status: Work In Progress Issue or Pull Request work is in Progress labels Nov 8, 2021
@blackfalcon blackfalcon mentioned this issue Nov 9, 2021
Merged
6 tasks
blackfalcon added a commit that referenced this issue Nov 9, 2021
@blackfalcon
fix(style): add background color to checkbox #44
80437f3
@blackfalcon blackfalcon changed the title auro-checkbox: Appears translucent in prod, needs to be filled with white Appears translucent in prod, needs to be filled with white Nov 9, 2021
@blackfalcon blackfalcon added Status: Review Needed Work is completed, user is requesting feedback and removed Status: Proposal labels Nov 9, 2021
blackfalcon added a commit that referenced this issue Nov 9, 2021
@blackfalcon
fix(style): add background color to checkbox #44
2b0d8fb
AuroDesignSystem pushed a commit that referenced this issue Nov 9, 2021
@semantic-release-bot
chore(release): 1.1.8 [skip ci]
9600452 
## [1.1.8](v1.1.7...v1.1.8) (2021-11-09)

### Bug Fixes

* **style:** add background color to checkbox [#44](#44) ([2b0d8fb](2b0d8fb))
* **style:** update border style for disabled element [#46](#46) ([fc08133](fc08133))
@KaylaBlyton1
Copy link
Author

@blackfalcon - Thank you for making this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-checkbox Status: Review Needed Work is completed, user is requesting feedback Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update UI of the checkbox element AlaskaAirlines/auro-checkbox
3 participants
@blackfalcon @braven112 @KaylaBlyton1