Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled border color #46

Closed
blackfalcon opened this issue Nov 7, 2021 · 3 comments · Fixed by #48
Closed

Disabled border color #46

blackfalcon opened this issue Nov 7, 2021 · 3 comments · Fixed by #48
Assignees
@blackfalcon @leeejune
Labels
auro-checkbox Status: Review Needed Work is completed, user is requesting feedback Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Describe the bug

It appears that the disabled border color is the same as the primary state border color.

Screen Shot 2021-11-07 at 12 24 07 PM

Screen Shot 2021-11-07 at 12 24 14 PM

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://auro.alaskaair.com/components/auro/checkbox
  2. Inslect on the shadow DOM of auro-checkbox
  3. See error

Expected behavior

There is no expected behavior, but this seems incorrect. We should review past design specs to find out of the auro CE is out of spec with the initial design.
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-input Nov 8, 2021
@leeejune
Copy link
Contributor

leeejune commented Nov 8, 2021

https://www.figma.com/file/wU5lxm5roZpGkm6Af5w8a9/Checkbox?node-id=322%3A298
Changes made to the blueprint. The stroke of a disabled checkbox is now "auro-color-border-disabled-on-light"

@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label Nov 8, 2021
@blackfalcon blackfalcon self-assigned this Nov 8, 2021
@blackfalcon
Copy link
Member Author

@leeejune thanks. I will make the CSS updates shortly. Is it on your list to create the Figma/Release notes for this page?

@blackfalcon
Copy link
Member Author

Yup... #41

blackfalcon added a commit that referenced this issue Nov 8, 2021
@blackfalcon
fix(style): update border style for disabled element #46
7ca5ce7
@blackfalcon blackfalcon mentioned this issue Nov 8, 2021
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Nov 8, 2021 that will close this issue
Update UI of the checkbox element #48
Merged
6 tasks
@blackfalcon blackfalcon added the Status: Review Needed Work is completed, user is requesting feedback label Nov 9, 2021
blackfalcon added a commit that referenced this issue Nov 9, 2021
@blackfalcon
fix(style): update border style for disabled element #46
fc08133
AuroDesignSystem pushed a commit that referenced this issue Nov 9, 2021
@semantic-release-bot
chore(release): 1.1.8 [skip ci]
9600452 
## [1.1.8](v1.1.7...v1.1.8) (2021-11-09)

### Bug Fixes

* **style:** add background color to checkbox [#44](#44) ([2b0d8fb](2b0d8fb))
* **style:** update border style for disabled element [#46](#46) ([fc08133](fc08133))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@leeejune leeejune

Labels
auro-checkbox Status: Review Needed Work is completed, user is requesting feedback Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update UI of the checkbox element AlaskaAirlines/auro-checkbox
2 participants
@blackfalcon @leeejune