Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy es5 bundling resources #63

Closed
AuroDesignSystem opened this issue Apr 10, 2023 · 0 comments · Fixed by #72 or #78
Closed

Remove legacy es5 bundling resources #63

AuroDesignSystem opened this issue Apr 10, 2023 · 0 comments · Fixed by #72 or #78
Assignees
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Refactoring A code change that neither fixes a bug nor adds a feature

Comments

@AuroDesignSystem
Copy link
Collaborator

AuroDesignSystem commented Apr 10, 2023

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

Related context

See linked commits for update references.

This issue was copied from #61 by @blackfalcon.

@AuroDesignSystem AuroDesignSystem added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Apr 10, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-header Apr 10, 2023
@blackfalcon blackfalcon added this to the Icon: Node 18+ support milestone Apr 10, 2023
@irma-kurnia-alaska irma-kurnia-alaska self-assigned this Apr 17, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label Apr 17, 2023
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue Apr 17, 2023
3 tasks
@blackfalcon blackfalcon linked a pull request Apr 17, 2023 that will close this issue
3 tasks
blackfalcon added a commit that referenced this issue Apr 21, 2023
blackfalcon added a commit that referenced this issue Apr 21, 2023
blackfalcon added a commit that referenced this issue Apr 21, 2023
@settings settings bot removed the auro-icon label Apr 21, 2023
AuroDesignSystem pushed a commit that referenced this issue Apr 21, 2023
## [3.4.4](v3.4.3...v3.4.4) (2023-04-21)

### Reverts

* Revert "perf(es5): Remove legacy es5 bundling resources #63" ([82669c2](82669c2)), closes [#63](#63)
* Revert "perf(sass): Update Sass to use dart-sass dependency #64" ([dded5b0](dded5b0)), closes [#64](#64)
* Revert "perf(husky): pre-commit and husky update #65" ([654a082](654a082)), closes [#65](#65)
* Revert "docs(template): update issue templates #70" ([7419b12](7419b12)), closes [#70](#70)
* Revert "build(npm): update npm namespace #71" ([f03729f](f03729f)), closes [#71](#71)
* Revert "feat(ts): add support for typescript users #69" ([1b45723](1b45723)), closes [#69](#69)
* Revert "chore(deps): full dependency update" ([25bb33c](25bb33c))
* Revert "perf(lit): update component to Lit2.0 #68" ([687e89a](687e89a)), closes [#68](#68)
* Revert "perf(server): update to use single shell" ([034e846](034e846))
* Revert "perf(node18): update core features to support node 18+ #66" ([1b0fb9a](1b0fb9a)), closes [#66](#66)
* Revert "chore(configs): release is missing required assets #74" ([bc6f712](bc6f712)), closes [#74](#74)
* Revert "feat() : support element name extension feature #62" ([d9fe35a](d9fe35a)), closes [#62](#62)
* Revert "docs(issues): update bug template" ([2221afd](2221afd))
* Revert "feat(ts): move the package of typescript into devDependencies" ([789a6f4](789a6f4))
* Revert "chore(deps): full dependency update" ([26aadc9](26aadc9))
* Revert "chore: additional cleanup of legacy code This commit removes legacy content from current resources and deleted files that are no longer required." ([79c61dc](79c61dc))
* Revert "deps: remove unused resources" ([9eaba53](9eaba53))
* Revert "chore: remove unused resource" ([a720ef9](a720ef9))
* Revert "chore: cleanup of legacy code" ([d2151d0](d2151d0))
* Revert "build(husky): remove package.json config #65" ([d2b00ee](d2b00ee)), closes [#65](#65)
* Revert "build(husky): update package-lock.json" ([0dc802c](0dc802c))
* Revert "build: update automated api generation script" ([b3a8021](b3a8021))
* Revert "docs: update to component registration function" ([fe459d3](fe459d3))
* Revert "build(husky): update resource to be executable #65" ([f1d83e0](f1d83e0)), closes [#65](#65)
* Revert "docs: update postinstall message" ([361a4a0](361a4a0))
@blackfalcon blackfalcon mentioned this issue Apr 21, 2023
6 tasks
@blackfalcon blackfalcon linked a pull request Apr 21, 2023 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Apr 22, 2023
# [4.0.0](v3.4.4...v4.0.0) (2023-04-22)

### Build System

* **npm:** update npm namespace [#71](#71) ([cb46d4f](cb46d4f))

### Features

* **ts:** add support for typescript users [#69](#69) ([d01bbb6](d01bbb6))
* **ts:** move the package of typescript into devDependencies ([684f626](684f626))

### Performance Improvements

* **es5:** Remove legacy es5 bundling resources [#63](#63) ([e9842a5](e9842a5))
* **husky:** pre-commit and husky update [#65](#65) ([4a0996d](4a0996d))
* **lit:** update component to Lit2.0 [#68](#68) ([e962e25](e962e25))
* **node18:** update core features to support node 18+ [#66](#66) ([e1e5f97](e1e5f97))
* **sass:** Update Sass to use dart-sass dependency [#64](#64) ([e38f7de](e38f7de))
* **server:** update to use single shell ([15f74ac](15f74ac))

### BREAKING CHANGES

* **npm:** This update requires a MAJOR release
as the namespace of the element has been changed.

Changes to be committed:
modified:   README.md
modified:   package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants