Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit and husky update #65

Closed
AuroDesignSystem opened this issue Apr 10, 2023 · 0 comments · Fixed by #72 or #78
Closed

Pre-commit and husky update #65

AuroDesignSystem opened this issue Apr 10, 2023 · 0 comments · Fixed by #72 or #78
Assignees
@irma-kurnia-alaska
Labels
Status: Work In Progress Issue or Pull Request work is in Progress
Milestone
Icon: Node 18+ su...

Comments

@AuroDesignSystem
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The current badge element is well behind recent versions of core support functions.

Describe the solution you'd like

Update the following core features of the badge element

  1. husky pre-commit hooks
  2. update to wc-test-runner

The following outlines the steps needed for updating any repo to the latest version of Husky.

  1. npx husky-init
  2. npm i @open-wc/testing@latest @web/test-runner@latest @web/dev-server@latest --save-dev
  3. npm run prepare
  4. chmod ug+x .husky/*
  5. chmod ug+x .git/hooks/*
  6. Update package.json - "test": "wtr --coverage", and "test:watch": "wtr --watch",
  7. Add web-test-runner.config.mjs
  8. Update .husky/pre-commit and necessary pre-commit actions
  9. Delete legacy Husky configs from package.json
  10. Delete karma.conf.js file
  11. Uninstall @open-wc/testing-karma

Exit criteria

This issue will not be considered complete once the listed core features are updated along with all associated dependencies and all features work as previously expected with node 18 installed.

This issue was copied from #43 by @blackfalcon.

This issue was copied from #63 by @blackfalcon.
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-header Apr 10, 2023
@blackfalcon blackfalcon added this to the Icon: Node 18+ support milestone Apr 10, 2023
@irma-kurnia-alaska irma-kurnia-alaska self-assigned this Apr 17, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label Apr 17, 2023
irma-kurnia-alaska pushed a commit that referenced this issue Apr 17, 2023
@irma-kurnia-phtn
perf(husky): pre-commit and husky update #65
e3e7ed8
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue Apr 17, 2023
Merged
3 tasks
@blackfalcon blackfalcon linked a pull request Apr 17, 2023 that will close this issue
Node 18+ Update #72
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Apr 19, 2023
@irma-kurnia-phtn @blackfalcon
perf(husky): pre-commit and husky update #65
80d7275
irma-kurnia-alaska pushed a commit that referenced this issue Apr 21, 2023
@irma-kurnia-phtn
build(husky): remove package.json config #65
04ad427 
Changes to be committed:
modified:   package.json
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
build(husky): update resource to be executable #65
a453703 
Changes to be committed:
modified:   .husky/pre-commit
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
build(husky): update resource to be executable #65
894c2c2 
Changes to be committed:
modified:   .husky/pre-commit
blackfalcon pushed a commit that referenced this issue Apr 21, 2023
@irma-kurnia-phtn @blackfalcon
build(husky): remove package.json config #65
6006071 
Changes to be committed:
modified:   package.json
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
build(husky): update resource to be executable #65
dc1f5a7 
Changes to be committed:
modified:   .husky/pre-commit
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): update resource to be executable #65"
0cf5853 
This reverts commit e932879.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): remove package.json config #65"
29ec85e 
This reverts commit 24f891f.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "perf(husky): pre-commit and husky update #65"
16312a1 
This reverts commit 475700f.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): update resource to be executable #65"
ca31460 
This reverts commit e932879.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): remove package.json config #65"
6dbf2cd 
This reverts commit 24f891f.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "perf(husky): pre-commit and husky update #65"
89b0c06 
This reverts commit 475700f.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): update resource to be executable #65"
f1d83e0 
This reverts commit e932879.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "build(husky): remove package.json config #65"
d2b00ee 
This reverts commit 24f891f.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "perf(husky): pre-commit and husky update #65"
654a082 
This reverts commit 475700f.
@settings settings bot removed auro-icon labels Apr 21, 2023
AuroDesignSystem pushed a commit that referenced this issue Apr 21, 2023
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
81d2021 
## [3.4.4](v3.4.3...v3.4.4) (2023-04-21)

### Reverts

* Revert "perf(es5): Remove legacy es5 bundling resources #63" ([82669c2](82669c2)), closes [#63](#63)
* Revert "perf(sass): Update Sass to use dart-sass dependency #64" ([dded5b0](dded5b0)), closes [#64](#64)
* Revert "perf(husky): pre-commit and husky update #65" ([654a082](654a082)), closes [#65](#65)
* Revert "docs(template): update issue templates #70" ([7419b12](7419b12)), closes [#70](#70)
* Revert "build(npm): update npm namespace #71" ([f03729f](f03729f)), closes [#71](#71)
* Revert "feat(ts): add support for typescript users #69" ([1b45723](1b45723)), closes [#69](#69)
* Revert "chore(deps): full dependency update" ([25bb33c](25bb33c))
* Revert "perf(lit): update component to Lit2.0 #68" ([687e89a](687e89a)), closes [#68](#68)
* Revert "perf(server): update to use single shell" ([034e846](034e846))
* Revert "perf(node18): update core features to support node 18+ #66" ([1b0fb9a](1b0fb9a)), closes [#66](#66)
* Revert "chore(configs): release is missing required assets #74" ([bc6f712](bc6f712)), closes [#74](#74)
* Revert "feat() : support element name extension feature #62" ([d9fe35a](d9fe35a)), closes [#62](#62)
* Revert "docs(issues): update bug template" ([2221afd](2221afd))
* Revert "feat(ts): move the package of typescript into devDependencies" ([789a6f4](789a6f4))
* Revert "chore(deps): full dependency update" ([26aadc9](26aadc9))
* Revert "chore: additional cleanup of legacy code This commit removes legacy content from current resources and deleted files that are no longer required." ([79c61dc](79c61dc))
* Revert "deps: remove unused resources" ([9eaba53](9eaba53))
* Revert "chore: remove unused resource" ([a720ef9](a720ef9))
* Revert "chore: cleanup of legacy code" ([d2151d0](d2151d0))
* Revert "build(husky): remove package.json config #65" ([d2b00ee](d2b00ee)), closes [#65](#65)
* Revert "build(husky): update package-lock.json" ([0dc802c](0dc802c))
* Revert "build: update automated api generation script" ([b3a8021](b3a8021))
* Revert "docs: update to component registration function" ([fe459d3](fe459d3))
* Revert "build(husky): update resource to be executable #65" ([f1d83e0](f1d83e0)), closes [#65](#65)
* Revert "docs: update postinstall message" ([361a4a0](361a4a0))
blackfalcon pushed a commit that referenced this issue Apr 21, 2023
@irma-kurnia-phtn @blackfalcon
perf(husky): pre-commit and husky update #65
b00a68d
@blackfalcon blackfalcon mentioned this issue Apr 21, 2023
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Apr 21, 2023 that will close this issue
Node 18+ updates #78
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Apr 22, 2023
@irma-kurnia-phtn @blackfalcon
perf(husky): pre-commit and husky update #65
4a0996d
blackfalcon pushed a commit that referenced this issue Apr 22, 2023
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
003bce9 
# [4.0.0](v3.4.4...v4.0.0) (2023-04-22)

### Build System

* **npm:** update npm namespace [#71](#71) ([cb46d4f](cb46d4f))

### Features

* **ts:** add support for typescript users [#69](#69) ([d01bbb6](d01bbb6))
* **ts:** move the package of typescript into devDependencies ([684f626](684f626))

### Performance Improvements

* **es5:** Remove legacy es5 bundling resources [#63](#63) ([e9842a5](e9842a5))
* **husky:** pre-commit and husky update [#65](#65) ([4a0996d](4a0996d))
* **lit:** update component to Lit2.0 [#68](#68) ([e962e25](e962e25))
* **node18:** update core features to support node 18+ [#66](#66) ([e1e5f97](e1e5f97))
* **sass:** Update Sass to use dart-sass dependency [#64](#64) ([e38f7de](e38f7de))
* **server:** update to use single shell ([15f74ac](15f74ac))

### BREAKING CHANGES

* **npm:** This update requires a MAJOR release
as the namespace of the element has been changed.

Changes to be committed:
modified:   README.md
modified:   package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Milestone
Icon: Node 18+ support
Development

Successfully merging a pull request may close this issue.

Node 18+ Update AlaskaAirlines/auro-icon
Node 18+ updates AlaskaAirlines/auro-icon
3 participants
@blackfalcon @AuroDesignSystem @irma-kurnia-alaska